ref: Add experimental streaming API (5) #6898
sentrivanatest-integrations-misc.yml
on: pull_request
Matrix: Misc
All Misc tests passed
2s
Annotations
22 errors and 2 warnings
|
Misc (3.6, ubuntu-22.04)
Action failed: Failed to parse any JUnit XML files
|
|
Misc (3.6, ubuntu-22.04)
Failed to parse /__w/sentry-python/sentry-python/.junitxml: Cannot read properties of undefined (reading 'addChild')
|
|
Misc (3.11, ubuntu-22.04)
Canceling since a higher priority waiting request for Test Misc-ivana/span-first-5-add-start-span-api exists
|
|
Misc (3.11, ubuntu-22.04)
The operation was canceled.
|
|
Misc (3.8, ubuntu-22.04)
Canceling since a higher priority waiting request for Test Misc-ivana/span-first-5-add-start-span-api exists
|
|
Misc (3.8, ubuntu-22.04)
The operation was canceled.
|
|
Misc (3.10, ubuntu-22.04)
Canceling since a higher priority waiting request for Test Misc-ivana/span-first-5-add-start-span-api exists
|
|
Misc (3.10, ubuntu-22.04)
The operation was canceled.
|
|
Misc (3.9, ubuntu-22.04)
Canceling since a higher priority waiting request for Test Misc-ivana/span-first-5-add-start-span-api exists
|
|
Misc (3.9, ubuntu-22.04)
The operation was canceled.
|
|
Misc (3.7, ubuntu-22.04)
Canceling since a higher priority waiting request for Test Misc-ivana/span-first-5-add-start-span-api exists
|
|
Misc (3.7, ubuntu-22.04)
The operation was canceled.
|
|
Misc (3.14, ubuntu-22.04)
Canceling since a higher priority waiting request for Test Misc-ivana/span-first-5-add-start-span-api exists
|
|
Misc (3.14, ubuntu-22.04)
The operation was canceled.
|
|
Misc (3.12, ubuntu-22.04)
Canceling since a higher priority waiting request for Test Misc-ivana/span-first-5-add-start-span-api exists
|
|
Misc (3.12, ubuntu-22.04)
The operation was canceled.
|
|
Misc (3.14t, ubuntu-22.04)
Canceling since a higher priority waiting request for Test Misc-ivana/span-first-5-add-start-span-api exists
|
|
Misc (3.14t, ubuntu-22.04)
The operation was canceled.
|
|
Misc (3.13, ubuntu-22.04)
Canceling since a higher priority waiting request for Test Misc-ivana/span-first-5-add-start-span-api exists
|
|
Misc (3.13, ubuntu-22.04)
The operation was canceled.
|
|
All Misc tests passed
Process completed with exit code 1.
|
|
Test Misc
Canceling since a higher priority waiting request for Test Misc-ivana/span-first-5-add-start-span-api exists
|
|
Dead code: NoOpStreamedSpan check at line 1216 is unreachable:
sentry_sdk/scope.py#L1216
The `isinstance(parent_span, NoOpStreamedSpan)` check at line 1216 can never be true. At lines 1192-1195, when `parent_span` is `NoOpStreamedSpan`, it is reassigned to `self.span` (which returns `Optional[Span]` from the old tracing API). After this reassignment, `parent_span` will either be `None` or an old `Span` object, never a `NoOpStreamedSpan`. This indicates either dead code that should be removed, or a logic error in the control flow.
|
|
New start_span API lacks test coverage:
sentry_sdk/traces.py#L67
The new `start_span` function and expanded `StreamedSpan` class have no corresponding test coverage. While the PR description states this is experimental code, the skill guidelines require appropriate test coverage for functional changes. No tests were found for `start_span`, `start_streamed_span`, or the new `StreamedSpan` attributes (`_parent_span_id`, `_segment`, `_parent_sampled`, `_scope`, `_baggage`).
|
Artifacts
Produced during runtime
| Name | Size | Digest | |
|---|---|---|---|
|
codecov-test-results-ivana-span-first-5-add-start-span-api-test-misc
Expired
|
230 Bytes |
sha256:6ed5214d7011b9670cbba66e356926f045bb0de9730e2a9ecc0aa191c59a599d
|
|