Skip to content

Commit 61b260c

Browse files
sentrivanaclaude
andcommitted
test(aiohttp): Unfurl spans explicitly instead of using pop()
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent a96301d commit 61b260c

1 file changed

Lines changed: 5 additions & 12 deletions

File tree

tests/integrations/aiohttp/test_aiohttp.py

Lines changed: 5 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1226,8 +1226,7 @@ async def hello(request):
12261226

12271227
sentry_sdk.flush()
12281228

1229-
items.pop() # drop the test client's outer segment
1230-
(server_span,) = [item.payload for item in items]
1229+
server_span, _client_segment = [item.payload for item in items]
12311230

12321231
# send_default_pii defaults to False, so _filter_headers substitutes
12331232
# sensitive headers with SENSITIVE_DATA_SUBSTITUTE ("[Filtered]"). The
@@ -1267,8 +1266,7 @@ async def hello(request):
12671266

12681267
sentry_sdk.flush()
12691268

1270-
items.pop() # drop the test client's outer segment
1271-
(server_span,) = [item.payload for item in items]
1269+
server_span, _client_segment = [item.payload for item in items]
12721270

12731271
# With send_default_pii=True, _filter_headers is a no-op and the original
12741272
# value reaches the span attribute.
@@ -1396,10 +1394,7 @@ async def hello(request):
13961394
assert error_event.type == "event"
13971395
assert error_event.payload["exception"]["values"][0]["type"] == "ZeroDivisionError"
13981396

1399-
spans = items[1:]
1400-
assert spans[-1].type == "span"
1401-
segment = spans.pop().payload
1402-
(server_span,) = [item.payload for item in spans]
1397+
server_span, segment = [item.payload for item in items[1:]]
14031398

14041399
assert segment["is_segment"] is True
14051400
assert segment["attributes"]["sentry.op"] == "http.client"
@@ -1441,8 +1436,7 @@ async def hello(request):
14411436
sentry_sdk.flush()
14421437

14431438
assert len(items) == 2
1444-
segment = items.pop().payload
1445-
(server_span,) = [item.payload for item in items]
1439+
server_span, segment = [item.payload for item in items]
14461440

14471441
assert segment["is_segment"] is True
14481442
assert segment["attributes"]["sentry.op"] == "http.client"
@@ -1479,8 +1473,7 @@ async def hello(request):
14791473
sentry_sdk.flush()
14801474

14811475
assert len(items) == 2
1482-
segment = items.pop().payload
1483-
(server_span,) = [item.payload for item in items]
1476+
server_span, segment = [item.payload for item in items]
14841477

14851478
assert segment["is_segment"] is True
14861479
assert segment["attributes"]["sentry.op"] == "http.client"

0 commit comments

Comments
 (0)