-
Notifications
You must be signed in to change notification settings - Fork 558
Open
Labels
Component: TestsDealing with testsDealing with testsImprovementIntegration: QuartPythonSDKSDKQuality ImprovementTriagedHas been looked at recently during old issue triageHas been looked at recently during old issue triage
Description
Our quart tests failed to detect that the Quart integration was completely broken. We should improve them so that they would have detected the failures in the below situation:
It is very surprising that our test suite did not detect that this integration was completely broken. Perhaps, this is a limitation of the Quart
test_client
we use in testing. We should certainly add tests to make sure we do not break in this way again, but that can likely be done later, most important is to quickly fix the broken integration ASAP
Originally posted by @szokeasaurusrex in #3043 (comment)
Metadata
Metadata
Assignees
Labels
Component: TestsDealing with testsDealing with testsImprovementIntegration: QuartPythonSDKSDKQuality ImprovementTriagedHas been looked at recently during old issue triageHas been looked at recently during old issue triage