Support not filtering exception logs by `ignore_errors`

[ddabble]

Problem Statement

We have a Django application that catches all exceptions through django-rest-framework's exception handler functionality, followed by logging them through a logging.getLogger().exception() call.

We've set the ignore_errors option to not create Sentry issues for some exceptions, but we'd still like for those exception logs to be sent to Sentry Structured Logs. However, it seems like those logs are prevented from being sent by the standard ignore_errors mechanism.

We can of course replace the previously mentioned exception() call with a call to logging.getLogger().error() (and not provide exc_info), but that seems like a suboptimal solution, as using exception() is (probably) the most idiomatic way to log exceptions.

Solution Brainstorm

Maybe add a new option to sentry_sdk.init() called ignore_logged_errors (that defaults to the value of ignore_errors if not provided), which log records with exc_info are filtered by..? 🤔

Alternatively/additionally, you could let users provide a function for ignore_errors that gives more fine-grained control instead of just a list of exception classes - perhaps in the same vein as before_send/before_send_transaction.

In any case, it would be useful for the docs on ignore_errors to mention that exception logs are also filtered by it :)

[sentrivana]

Hey @ddabble, thanks for writing in. I don't believe ignore_errors filtering out logs is intended behavior. Will investigate and get back to you.

[sentrivana]

As far as I can tell logs don't go through the usual capture_event codepath that includes checking ignore_errors -- they're going through their own _capture_experimental_log function where we don't check ignore_errors (which is the correct behavior).

Confirmed that this sends an error log to Sentry:

import logging
import sentry_sdk

class MyException(Exception):
    pass

sentry_sdk.init(
    debug=True,
    _experiments={"enable_logs": True},
    ignore_errors=[MyException],
)

try:
    raise MyException("Oh no!")
except:
    logging.exception("oops")

So it looks like there's something else going on. Do you have an example for us to reproduce the issue?

[ddabble]

Ah, you're indeed correct! I was debugging, and for some reason only considered the path of LoggingIntegration._handler and not LoggingIntegration._sentry_logs_handler 😅

In any case, thanks a bunch for the thorough response 😊