Skip to content

Commit b631dfa

Browse files
antonisclaude
andcommitted
fix(ci): Fix metro blocklist blocking expo-symbols android dir and update comments
The blocklist regex `.*\\android\\.*` was too broad - after being combined by Metro's exclusionList, it blocked `expo-symbols/build/android` directory from being resolved, causing Android bundle export to fail. Scope the regex to only block the sample app's own android/ build directory. Also update comments to reflect SDK 55 and RN 0.83. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 7603d15 commit b631dfa

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

.github/workflows/sample-application-expo.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ jobs:
107107
[[ "${{ matrix.build-type }}" == "production" ]] && ENABLE_PROD=1 || ENABLE_PROD=0
108108
[[ "${{ matrix.ios-use-frameworks }}" == "dynamic-frameworks" ]] && export USE_FRAMEWORKS=dynamic
109109
echo "ENABLE_PROD=$ENABLE_PROD"
110-
# Monorepo fix: Point Sentry SDK to correct React Native version (0.81 vs 0.80)
110+
# Monorepo fix: Point Sentry SDK to correct React Native version (0.83 vs 0.80)
111111
export REACT_NATIVE_NODE_MODULES_DIR="$(cd ../node_modules/react-native && pwd)"
112112
PRODUCTION=$ENABLE_PROD pod install
113113
cat Podfile.lock | grep $RN_SENTRY_POD_NAME
@@ -116,7 +116,7 @@ jobs:
116116
if: ${{ matrix.platform == 'android' }}
117117
working-directory: samples/expo/android
118118
env:
119-
# Increase memory for Expo SDK 54 lint tasks
119+
# Increase memory for Expo SDK 55 lint tasks
120120
GRADLE_OPTS: "-Dorg.gradle.jvmargs=-Xmx4g -XX:MaxMetaspaceSize=1g"
121121
run: |
122122
[[ "${{ matrix.build-type }}" == "production" ]] && CONFIG='Release' || CONFIG='Debug'

dev-packages/utils/metro.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ const withMonorepo = config => {
3535
(!!config.resolver.blockList && [config.resolver.blockList]) ||
3636
[]),
3737
...getBlockList(monorepoPackages, ['react-native', 'react']),
38-
new RegExp('.*\\android\\.*'), // Required for Windows in order to run the Sample.
38+
new RegExp(`${projectRoot.replace(/[.*+?^${}()|[\]\\]/g, '\\$&')}[/\\\\]android[/\\\\].*`), // Required for Windows in order to run the Sample.
3939
];
4040
config.resolver.blockList = exclusionList(blockList);
4141

0 commit comments

Comments
 (0)