Ref: Use danger to check ready-for-merge label (#5366)

* initial implementation

* truck forgot to sent the package

* quality of life nits

* just error for all

* danger react to label changes

* refresh CI

* add logs

* fixed label name

Author: lucas-zimerman

.github/workflows/danger.yml

@@ -2,13 +2,13 @@ name: Danger
 
 on:
   pull_request:
-    types: [opened, synchronize, reopened, edited, ready_for_review]
+    types: [opened, synchronize, reopened, edited, ready_for_review, labeled, unlabeled]
 
 jobs:
   danger:
     runs-on: ubuntu-latest
     steps:
       - uses: getsentry/github-workflows/danger@17cc15eb58ea3687cd8f2714a4192dcee4aa09ef
         with:
-          extra-dangerfile: scripts/check-replay-stubs.js
+          extra-dangerfile: scripts/check-additional-danger.js
           extra-install-packages: "curl unzip openjdk-17-jre-headless"

scripts/check-additional-danger.js

@@ -0,0 +1,14 @@
+async function safeRun(fnPath, { fail, warn, message, markdown, danger }) {
+  const fn = require(fnPath);
+  try {
+    return await fn({ fail, warn, message, markdown, danger });
+  } catch (error) {
+    warn(`Failed to run ${fnPath}: ${error.message}`);
+  }
+}
+
+
+module.exports = async function ({ fail, warn, message, markdown, danger }) {
+  await safeRun('./check-github-label', { fail, warn, message, markdown, danger });
+  await safeRun('./check-replay-stubs', { fail, warn, message, markdown, danger });
+};

scripts/check-github-label.js

@@ -0,0 +1,7 @@
+module.exports = async function ({ fail, warn, __, ___, danger }) {
+  const isReeadyForMerge = danger.github.issue.labels.some(label => label.name === 'ready-to-merge');
+  if (!isReeadyForMerge) {
+    // Ideally we could check for `isDraft` but this information is not easily available.
+    fail('Pull request is not ready for merge, please add the "ready-to-merge" label to the pull request');
+  }
+};