-
-
Notifications
You must be signed in to change notification settings - Fork 354
Move sentry-cocoa enableLogs out of experimental
#5267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
### Features
- Move `sentry-cocoa` `enableLogs` out of experimental ([#5267](https://github.com/getsentry/sentry-react-native/pull/5267))If none of the above apply, you can opt out of this check by adding |
senry-cocoa enableLogs out of experimental
senry-cocoa enableLogs out of experimentalsentry-cocoa enableLogs out of experimental
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ede2a89 | 414.58 ms | 395.16 ms | -19.42 ms |
| 3a9200e+dirty | 451.42 ms | 481.13 ms | 29.71 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ede2a89 | 17.75 MiB | 19.68 MiB | 1.94 MiB |
| 3a9200e+dirty | 17.75 MiB | 19.70 MiB | 1.95 MiB |
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 3a9200e+dirty | 341.91 ms | 405.08 ms | 63.17 ms |
| ede2a89+dirty | 398.04 ms | 486.04 ms | 88.00 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 3a9200e+dirty | 7.15 MiB | 8.43 MiB | 1.28 MiB |
| ede2a89+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
# Conflicts: # packages/core/ios/RNSentry.mm
antonis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
I'll proceed with merging in cocoa-v9
📜 Description
senry-cocoaenableLogsout of experimental💡 Motivation and Context
Branches from #5153 so coco CI is happy.
Relates to getsentry/sentry-cocoa#6359
This can only be merged once #5153 is merged and
sentry-cocoav9 is released.💚 How did you test it?
CI
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps