Skip to content

Conversation

@antonis
Copy link
Contributor

@antonis antonis commented Nov 11, 2025

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Breaking changes:

SubPRs:

💡 Motivation and Context

See #5273

💚 How did you test it?

CI, Manual

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

@antonis
Copy link
Contributor Author

antonis commented Nov 11, 2025

Marking as Blocked while the Cocoa v9 is in Alpha

itaybre and others added 3 commits November 11, 2025 16:38
* fix: Fixes SentryScreenFrames use after being converted to Swift

* Fix build

---------

Co-authored-by: Antonis Lilis <[email protected]>
* fix: Fixes SentryScreenFrames use after being converted to Swift

* Fix build

* Use non-experimental enableLogs

* bump target

* remove enable tracing

* Update enableLogs tests

---------

Co-authored-by: Itay Brenner <[email protected]>
Co-authored-by: Itay Brenner <[email protected]>
Co-authored-by: Antonis Lilis <[email protected]>
* fix: Fixes SentryScreenFrames use after being converted to Swift

* Fix build

* Use non-experimental enableLogs

* bump target

* remove enable tracing

* Update enableLogs tests

* chore: Fix RNSentry after SentryFramesTracker conversion to swift

* Run linter

* Remove unused debug image provider imports

* Remove imports

* chore: Remove deprecated user property

* chore: Remove use of deprecate integrations API (#5304)

* Remove use of integrations in tests

* chore: Remove use of deprecated prop (#5322)

* ref: Move options to wrapper

---------

Co-authored-by: Antonis Lilis <[email protected]>
Co-authored-by: Denis Andrasec <[email protected]>
Co-authored-by: Noah Martin <[email protected]>
@antonis antonis added the ready-to-merge Triggers the full CI test suite label Nov 11, 2025
@antonis
Copy link
Contributor Author

antonis commented Nov 11, 2025

Adding the ready-to-merge label to trigger all tests but it's not really ready to merge 😅

@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2025

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 438.56 ms 463.80 ms 25.24 ms
Size 43.94 MiB 48.85 MiB 4.91 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
af9331b+dirty 374.42 ms 425.68 ms 51.26 ms
07808fb+dirty 392.47 ms 451.94 ms 59.47 ms
88890fe+dirty 328.30 ms 319.85 ms -8.45 ms
785ffb1+dirty 380.65 ms 451.83 ms 71.18 ms
652f785+dirty 367.80 ms 390.71 ms 22.91 ms
b3b5b0d+dirty 361.42 ms 403.90 ms 42.48 ms
8d20c8e+dirty 469.90 ms 502.00 ms 32.10 ms
ea3e26e+dirty 399.98 ms 448.36 ms 48.38 ms
170d5ea+dirty 348.79 ms 406.94 ms 58.15 ms
05bef0e+dirty 451.63 ms 533.90 ms 82.27 ms

App size

Revision Plain With Sentry Diff
af9331b+dirty 7.15 MiB 8.41 MiB 1.26 MiB
07808fb+dirty 7.15 MiB 8.43 MiB 1.28 MiB
88890fe+dirty 7.15 MiB 8.44 MiB 1.28 MiB
785ffb1+dirty 7.15 MiB 8.42 MiB 1.27 MiB
652f785+dirty 43.94 MiB 48.82 MiB 4.88 MiB
b3b5b0d+dirty 7.15 MiB 8.41 MiB 1.26 MiB
8d20c8e+dirty 43.94 MiB 48.81 MiB 4.88 MiB
ea3e26e+dirty 43.94 MiB 48.82 MiB 4.88 MiB
170d5ea+dirty 7.15 MiB 8.42 MiB 1.27 MiB
05bef0e+dirty 7.15 MiB 8.43 MiB 1.28 MiB

@github-actions
Copy link
Contributor

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 426.98 ms 415.35 ms -11.63 ms
Size 43.75 MiB 47.99 MiB 4.24 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d916aa3 425.37 ms 427.02 ms 1.65 ms
05bef0e+dirty 349.78 ms 334.04 ms -15.74 ms
bc9680d 375.15 ms 401.12 ms 25.97 ms
69602ce 417.47 ms 443.52 ms 26.05 ms
136effd+dirty 398.57 ms 494.91 ms 96.34 ms
d751a5d+dirty 434.24 ms 486.08 ms 51.84 ms
8d20c8e+dirty 480.27 ms 503.35 ms 23.08 ms
8db9631+dirty 442.78 ms 461.96 ms 19.18 ms
46bd012 387.09 ms 404.47 ms 17.38 ms
1226664+dirty 347.45 ms 386.60 ms 39.15 ms

App size

Revision Plain With Sentry Diff
d916aa3 17.75 MiB 20.15 MiB 2.41 MiB
05bef0e+dirty 17.75 MiB 19.70 MiB 1.95 MiB
bc9680d 17.75 MiB 20.15 MiB 2.41 MiB
69602ce 17.75 MiB 19.68 MiB 1.94 MiB
136effd+dirty 43.75 MiB 47.99 MiB 4.23 MiB
d751a5d+dirty 17.75 MiB 19.68 MiB 1.94 MiB
8d20c8e+dirty 43.75 MiB 47.99 MiB 4.23 MiB
8db9631+dirty 17.75 MiB 19.70 MiB 1.96 MiB
46bd012 17.75 MiB 20.15 MiB 2.41 MiB
1226664+dirty 17.75 MiB 19.74 MiB 1.99 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2025

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1216.79 ms 1216.60 ms -0.20 ms
Size 3.41 MiB 4.63 MiB 1.21 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
c08359e+dirty 1200.59 ms 1211.81 ms 11.22 ms
459a438+dirty 1218.39 ms 1226.14 ms 7.75 ms
8d20c8e+dirty 1223.60 ms 1223.87 ms 0.27 ms
6479fd5+dirty 1207.80 ms 1215.12 ms 7.32 ms
a2bb688+dirty 1244.82 ms 1238.60 ms -6.22 ms
fa7bb7e+dirty 1226.27 ms 1241.88 ms 15.61 ms
d751a5d+dirty 1212.22 ms 1217.94 ms 5.71 ms
73f2455+dirty 1219.85 ms 1218.29 ms -1.56 ms
07808fb+dirty 1240.76 ms 1251.00 ms 10.24 ms
4a17c8f+dirty 1213.28 ms 1213.64 ms 0.36 ms

App size

Revision Plain With Sentry Diff
c08359e+dirty 3.19 MiB 4.38 MiB 1.19 MiB
459a438+dirty 3.19 MiB 4.55 MiB 1.36 MiB
8d20c8e+dirty 3.41 MiB 4.57 MiB 1.16 MiB
6479fd5+dirty 3.19 MiB 4.53 MiB 1.35 MiB
a2bb688+dirty 3.19 MiB 4.56 MiB 1.37 MiB
fa7bb7e+dirty 3.19 MiB 4.58 MiB 1.39 MiB
d751a5d+dirty 3.19 MiB 4.54 MiB 1.36 MiB
73f2455+dirty 3.41 MiB 4.58 MiB 1.17 MiB
07808fb+dirty 3.19 MiB 4.56 MiB 1.37 MiB
4a17c8f+dirty 3.41 MiB 4.58 MiB 1.17 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2025

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1228.13 ms 1228.83 ms 0.71 ms
Size 3.41 MiB 4.63 MiB 1.21 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
c08359e+dirty 1235.25 ms 1233.96 ms -1.29 ms
459a438+dirty 1222.12 ms 1214.60 ms -7.53 ms
8d20c8e+dirty 1216.62 ms 1220.31 ms 3.69 ms
6479fd5+dirty 1228.48 ms 1231.32 ms 2.84 ms
a2bb688+dirty 1223.53 ms 1232.90 ms 9.37 ms
fa7bb7e+dirty 1216.23 ms 1225.04 ms 8.81 ms
d751a5d+dirty 1215.57 ms 1220.56 ms 4.99 ms
73f2455+dirty 1213.49 ms 1211.96 ms -1.53 ms
07808fb+dirty 1233.31 ms 1232.77 ms -0.54 ms
4a17c8f+dirty 1226.36 ms 1219.28 ms -7.07 ms

App size

Revision Plain With Sentry Diff
c08359e+dirty 2.63 MiB 3.81 MiB 1.18 MiB
459a438+dirty 2.63 MiB 3.98 MiB 1.35 MiB
8d20c8e+dirty 3.41 MiB 4.57 MiB 1.16 MiB
6479fd5+dirty 2.63 MiB 3.96 MiB 1.33 MiB
a2bb688+dirty 2.63 MiB 3.99 MiB 1.36 MiB
fa7bb7e+dirty 2.63 MiB 4.01 MiB 1.38 MiB
d751a5d+dirty 2.63 MiB 3.98 MiB 1.34 MiB
73f2455+dirty 3.41 MiB 4.58 MiB 1.17 MiB
07808fb+dirty 2.63 MiB 3.99 MiB 1.36 MiB
4a17c8f+dirty 3.41 MiB 4.58 MiB 1.17 MiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Blocked ready-to-merge Triggers the full CI test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants