Apply clippy fixes and cherry-pick PRs (#610)

- Bump webpki-roots to ^0.25.1
- `debug-images` should be listed as a default feature
- Apply clippy suggestions and bump MSRV

---------

Co-authored-by: Marcus Pettersen Irgens <[email protected]>
Co-authored-by: Tim Fish <[email protected]>

Author: 3 people

.github/workflows/ci.yml

@@ -65,7 +65,7 @@ jobs:
       fail-fast: false
       matrix:
         os: [ubuntu-latest, macos-latest, windows-latest]
-        rust: [1.66.0]
+        rust: [1.67.0]
 
     name: Check / Test MSRV on ${{ matrix.os }}
     runs-on: ${{ matrix.os }}

README.md

@@ -93,12 +93,12 @@ best API and adding new features.
 We currently only verify this crate against a recent version of Sentry hosted on [sentry.io](https://sentry.io/) but it
 should work with on-prem Sentry versions 20.6 and later.
 
-The **Minimum Supported Rust Version** is currently at _1.66.0_.
+The **Minimum Supported Rust Version** is currently at _1.67.0_.
 The Sentry crates will support a _6 months_ old Rust version at time of release,
 and the MSRV will be increased in accordance with its dependencies.
 
 **Note**: Due to the misconfiguration in our workflow that verified the MSRV builds,
-we had to bump it all the way to _1.66.0_, breaking our own _6 months_ old rule.
+we had to bump it all the way to _1.67.0_, breaking our own _6 months_ old rule.
 As of version _0.30.0_, the workflow has been fixed, and the MSRV will be enforced correctly.
 
 ## Resources

clippy.toml

@@ -1 +1 @@
-msrv = "1.66.0"
+msrv = "1.67.0"

sentry-actix/Cargo.toml

@@ -10,7 +10,7 @@ description = """
 Sentry client extension for actix-web 3.
 """
 edition = "2021"
-rust-version = "1.66"
+rust-version = "1.67"
 
 [dependencies]
 actix-web = { version = "4", default-features = false }

sentry-anyhow/Cargo.toml

@@ -10,7 +10,7 @@ description = """
 Sentry integration for anyhow.
 """
 edition = "2021"
-rust-version = "1.66"
+rust-version = "1.67"
 
 [features]
 default = ["backtrace"]

sentry-backtrace/Cargo.toml

@@ -10,7 +10,7 @@ description = """
 Sentry integration and utilities for dealing with stacktraces.
 """
 edition = "2021"
-rust-version = "1.66"
+rust-version = "1.67"
 
 [dependencies]
 backtrace = "0.3.44"

sentry-backtrace/src/utils.rs

@@ -14,34 +14,34 @@ static HASH_FUNC_RE: Lazy<Regex> = Lazy::new(|| {
 
 static CRATE_HASH_RE: Lazy<Regex> = Lazy::new(|| {
     Regex::new(
-        r#"(?x)
+        r"(?x)
         \b(\[[a-f0-9]{16}\])
-    "#,
+    ",
     )
     .unwrap()
 });
 
 static CRATE_RE: Lazy<Regex> = Lazy::new(|| {
     Regex::new(
-        r#"(?x)
+        r"(?x)
         ^
         (?:_?<)?           # trait impl syntax
         (?:\w+\ as \ )?    # anonymous implementor
         ([a-zA-Z0-9_]+?)   # crate name
         (?:\.\.|::|\[)     # crate delimiter (.. or :: or [)
-    "#,
+    ",
     )
     .unwrap()
 });
 
 static COMMON_RUST_SYMBOL_ESCAPES_RE: Lazy<Regex> = Lazy::new(|| {
     Regex::new(
-        r#"(?x)
+        r"(?x)
         \$
             (SP|BP|RF|LT|GT|LP|RP|C|
                 u7e|u20|u27|u5b|u5d|u7b|u7d|u3b|u2b|u22)
         \$
-    "#,
+    ",
     )
     .unwrap()
 });

sentry-contexts/Cargo.toml

@@ -11,7 +11,7 @@ Sentry integration for os, device, and rust contexts.
 """
 build = "build.rs"
 edition = "2021"
-rust-version = "1.66"
+rust-version = "1.67"
 
 [dependencies]
 sentry-core = { version = "0.31.5", path = "../sentry-core" }

sentry-core/Cargo.toml

@@ -10,7 +10,7 @@ description = """
 Core sentry library used for instrumentation and integration development.
 """
 edition = "2021"
-rust-version = "1.66"
+rust-version = "1.67"
 
 [package.metadata.docs.rs]
 all-features = true

sentry-debug-images/Cargo.toml

@@ -10,7 +10,7 @@ description = """
 Sentry integration that adds the list of loaded libraries to events.
 """
 edition = "2021"
-rust-version = "1.66"
+rust-version = "1.67"
 
 [dependencies]
 findshlibs = "=0.10.2"