Skip to content

Commit c6e6d75

Browse files
committed
fix(taskworker) Remove pickle parameters from delete_groups
Don't put uuid() objects into evenstream_state, as they require pickle. Fixes #90765
1 parent a55817a commit c6e6d75

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

src/sentry/api/helpers/group_index/delete.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ def delete_group_list(
7979
delete_groups_task.apply_async(
8080
kwargs={
8181
"object_ids": group_ids,
82-
"transaction_id": transaction_id,
82+
"transaction_id": str(transaction_id),
8383
"eventstream_state": eventstream_state,
8484
},
8585
countdown=countdown,

src/sentry/eventstream/snuba.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,7 @@ def start_delete_groups(self, project_id: int, group_ids: Sequence[int]) -> Mapp
208208
raise ValueError("expected groups to delete!")
209209

210210
state = {
211-
"transaction_id": uuid4().hex,
211+
"transaction_id": str(uuid4().hex),
212212
"project_id": project_id,
213213
"group_ids": list(group_ids),
214214
"datetime": json.datetime_to_str(datetime.now(tz=timezone.utc)),

tests/sentry/issues/endpoints/test_organization_group_index.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -5613,7 +5613,7 @@ def assert_deleted_groups(self, groups: Sequence[Group]) -> None:
56135613

56145614
@patch("sentry.eventstream.backend")
56155615
def test_delete_by_id(self, mock_eventstream: MagicMock) -> None:
5616-
eventstream_state = {"event_stream_state": uuid4()}
5616+
eventstream_state = {"event_stream_state": str(uuid4())}
56175617
mock_eventstream.start_delete_groups = Mock(return_value=eventstream_state)
56185618

56195619
group1 = self.create_group(status=GroupStatus.RESOLVED)
@@ -5686,7 +5686,7 @@ def test_delete_by_id(self, mock_eventstream: MagicMock) -> None:
56865686

56875687
@patch("sentry.eventstream.backend")
56885688
def test_delete_performance_issue_by_id(self, mock_eventstream: MagicMock) -> None:
5689-
eventstream_state = {"event_stream_state": uuid4()}
5689+
eventstream_state = {"event_stream_state": str(uuid4())}
56905690
mock_eventstream.start_delete_groups = Mock(return_value=eventstream_state)
56915691

56925692
group1 = self.create_group(

0 commit comments

Comments
 (0)