fix(aci): camelCase action data fields in serializer (#104597)

we already made the fix to convert the action `config` fields to
camelCase in the action serializer, so we should do the same for the
`data` fields

Author: ameliahsu

src/sentry/workflow_engine/endpoints/serializers/action_serializer.py

@@ -32,7 +32,7 @@ def serialize(self, obj: Action, *args, **kwargs) -> ActionSerializerResponse:
             "id": str(obj.id),
             "type": obj.type,
             "integrationId": str(obj.integration_id) if obj.integration_id else None,
-            "data": obj.data,
+            "data": convert_dict_key_case(obj.data, snake_to_camel_case),
             "config": convert_dict_key_case(config, snake_to_camel_case),
             "status": obj.get_status_display(),
         }

tests/sentry/workflow_engine/endpoints/serializers/test_action_serializer.py

@@ -1,6 +1,7 @@
 from sentry.api.serializers import serialize
 from sentry.constants import ObjectStatus
 from sentry.notifications.models.notificationaction import ActionTarget
+from sentry.notifications.types import FallthroughChoiceType
 from sentry.testutils.cases import TestCase
 from sentry.testutils.skips import requires_snuba
 from sentry.workflow_engine.models import Action
@@ -103,3 +104,25 @@ def test_serialize_with_integration_and_config(self) -> None:
             },
             "status": "active",
         }
+
+    def test_serialize_with_data(self) -> None:
+        action = self.create_action(
+            type=Action.Type.EMAIL,
+            data={"fallthrough_type": FallthroughChoiceType.ACTIVE_MEMBERS},
+            config={
+                "target_type": ActionTarget.ISSUE_OWNERS,
+            },
+        )
+
+        result = serialize(action)
+
+        assert result == {
+            "id": str(action.id),
+            "type": "email",
+            "data": {"fallthroughType": "ActiveMembers"},
+            "integrationId": None,
+            "config": {
+                "targetType": "issue_owners",
+            },
+            "status": "active",
+        }

tests/sentry/workflow_engine/endpoints/test_organization_workflow_index.py

@@ -11,19 +11,11 @@
 from sentry.deletions.tasks.scheduled import run_scheduled_deletions
 from sentry.grouping.grouptype import ErrorGroupType
 from sentry.incidents.grouptype import MetricIssue
-from sentry.notifications.types import FallthroughChoiceType
 from sentry.testutils.asserts import assert_org_audit_log_exists
 from sentry.testutils.cases import APITestCase
 from sentry.testutils.outbox import outbox_runner
 from sentry.testutils.silo import region_silo_test
-from sentry.workflow_engine.models import (
-    Action,
-    DataConditionGroupAction,
-    DetectorWorkflow,
-    Workflow,
-    WorkflowDataConditionGroup,
-    WorkflowFireHistory,
-)
+from sentry.workflow_engine.models import Action, DetectorWorkflow, Workflow, WorkflowFireHistory
 from sentry.workflow_engine.models.data_condition import Condition
 from sentry.workflow_engine.typings.notification_action import (
     ActionTarget,
@@ -447,7 +439,7 @@ def test_create_workflow__with_config(self) -> None:
 
         assert response.status_code == 201
         new_workflow = Workflow.objects.get(id=response.data["id"])
-        assert new_workflow.config == self.valid_workflow["config"]
+        assert response.data == serialize(new_workflow)
 
     def test_create_workflow__with_triggers(self) -> None:
         self.valid_workflow["triggers"] = {
@@ -462,10 +454,7 @@ def test_create_workflow__with_triggers(self) -> None:
 
         assert response.status_code == 201
         new_workflow = Workflow.objects.get(id=response.data["id"])
-        assert new_workflow.when_condition_group is not None
-        assert str(new_workflow.when_condition_group.id) == response.data.get("triggers", {}).get(
-            "id"
-        )
+        assert response.data == serialize(new_workflow)
 
     @mock.patch(
         "sentry.notifications.notification_action.registry.action_validator_registry.get",
@@ -498,11 +487,7 @@ def test_create_workflow__with_actions(self, mock_action_validator: mock.MagicMo
 
         assert response.status_code == 201
         new_workflow = Workflow.objects.get(id=response.data["id"])
-        new_action_filters = WorkflowDataConditionGroup.objects.filter(workflow=new_workflow)
-        assert len(new_action_filters) == len(response.data.get("actionFilters", []))
-        assert str(new_action_filters[0].condition_group.id) == response.data.get(
-            "actionFilters", []
-        )[0].get("id")
+        assert response.data == serialize(new_workflow)
 
     @mock.patch(
         "sentry.notifications.notification_action.registry.action_validator_registry.get",
@@ -534,24 +519,7 @@ def test_create_workflow__with_fallthrough_type_action(
 
         assert response.status_code == 201
         new_workflow = Workflow.objects.get(id=response.data["id"])
-        new_action_filters = WorkflowDataConditionGroup.objects.filter(workflow=new_workflow)
-        assert len(new_action_filters) == len(response.data.get("actionFilters", []))
-        dcga = DataConditionGroupAction.objects.filter(
-            condition_group=new_action_filters[0].condition_group
-        ).first()
-        assert dcga
-        assert str(new_action_filters[0].condition_group.id) == response.data.get(
-            "actionFilters", []
-        )[0].get("id")
-        assert (
-            response.data.get("actionFilters")[0]
-            .get("actions")[0]
-            .get("data")
-            .get("fallthrough_type")
-            == FallthroughChoiceType.ACTIVE_MEMBERS.value
-        )
-        assert dcga.action.type == Action.Type.EMAIL
-        assert dcga.action.data == {"fallthrough_type": "ActiveMembers"}
+        assert response.data == serialize(new_workflow)
 
     @responses.activate
     def test_create_workflow_with_sentry_app_action(self) -> None:
@@ -587,19 +555,7 @@ def test_create_workflow_with_sentry_app_action(self) -> None:
             raw_data=self.valid_workflow,
         )
         updated_workflow = Workflow.objects.get(id=response.data["id"])
-        new_action_filters = WorkflowDataConditionGroup.objects.filter(workflow=updated_workflow)
-        dcga = DataConditionGroupAction.objects.filter(
-            condition_group=new_action_filters[0].condition_group
-        )
-        action = dcga[0].action
-
-        assert action.type == Action.Type.SENTRY_APP
-        assert action.config == {
-            "sentry_app_identifier": SentryAppIdentifier.SENTRY_APP_ID,
-            "target_identifier": str(self.sentry_app.id),
-            "target_type": ActionTarget.SENTRY_APP.value,
-        }
-        assert action.data["settings"] == self.sentry_app_settings
+        assert response.data == serialize(updated_workflow)
 
     @responses.activate
     def test_create_sentry_app_action_missing_settings(self) -> None:
@@ -679,19 +635,7 @@ def test_create_sentry_app_action_no_settings(self) -> None:
             raw_data=self.valid_workflow,
         )
         updated_workflow = Workflow.objects.get(id=response.data["id"])
-        new_action_filters = WorkflowDataConditionGroup.objects.filter(workflow=updated_workflow)
-        dcga = DataConditionGroupAction.objects.filter(
-            condition_group=new_action_filters[0].condition_group
-        )
-        action = dcga[0].action
-
-        assert action.type == Action.Type.SENTRY_APP
-        assert action.config == {
-            "sentry_app_identifier": SentryAppIdentifier.SENTRY_APP_ID,
-            "target_identifier": str(sentry_app.id),
-            "target_type": ActionTarget.SENTRY_APP.value,
-        }
-        assert action.data == {}
+        assert response.data == serialize(updated_workflow)
 
     def test_create_invalid_workflow(self) -> None:
         self.valid_workflow["name"] = ""