Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: file path limit exceeded #1723

Closed
chrmod opened this issue Jul 8, 2024 · 1 comment · Fixed by #1725
Closed

Windows: file path limit exceeded #1723

chrmod opened this issue Jul 8, 2024 · 1 comment · Fixed by #1725
Assignees
Labels
Bug Something isn't working

Comments

@chrmod
Copy link
Member

chrmod commented Jul 8, 2024

On some security configurations of Windows the file path is limited to 256 character. In this scenarios, Ghostery extension may fail to load if it is installed in a profile that's path is already relatively long.

Here is a list of longest file paths:

127 ./node_modules/@whotracksme/webextension-packages/packages/reporting/src/request/steps/token-telemetry/cached-entry-pipeline.js
120 ./node_modules/@whotracksme/webextension-packages/packages/reporting/src/request/steps/token-telemetry/token-pipeline.js
118 ./node_modules/@whotracksme/webextension-packages/packages/reporting/src/request/steps/token-telemetry/key-pipeline.js
116 ./node_modules/@whotracksme/webextension-packages/packages/reporting/src/request/steps/token-checker/token-domain.js
116 ./node_modules/@whotracksme/webextension-packages/packages/anonymous-communication/src/server-public-key-accessor.js
114 ./node_modules/@whotracksme/webextension-packages/packages/reporting/src/webrequest-pipeline/webrequest-context.js

It looks like the Anti-Tracking codebase is the culprit.

This issue is related to Ghostery 10 rollup and contributes to the list of problems listed in #1669

@chrmod chrmod added the Bug Something isn't working label Jul 8, 2024
@chrmod
Copy link
Member Author

chrmod commented Jul 8, 2024

We would probably do best to include a test if any of the files produced by build, does not exceed some desired length. Not sure what the limit should be, we can start with something not too constraining like a 100.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants