Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Links with identical accessible names and context serve equivalent purpose rule #4

Open
wants to merge 55 commits into
base: develop
Choose a base branch
from

Conversation

giacomo-petri
Copy link
Owner

@giacomo-petri giacomo-petri commented Jan 17, 2023

Current failed scenarios are ambiguous to users in general. With this changes I've updated failed scenarios, providing a clear visual context for sighted users, that doesn't reflect in an equal semantic context for AT users. I've also created an inapplicable example to highlight a scenario which is ambiguous to users in general.

Closes issue(s):

  • closes #XXX (ADD ISSUE NUMBER HERE)

Need for Call for Review:
This will require a 2 weeks Call for Review
I'm note sure about the timing here as multiple failed cases have been updated. I've set 2 weeks but feel free to update if needed.


Pull Request Etiquette

When creating PR:

  • Make sure you're requesting to pull a branch (right side) to the develop branch (left side).
  • Make sure you do not remove the "How to Review and Approve" section in your pull request description

After creating PR:

  • Add yourself (and co-authors) as "Assignees" for PR.
  • Add label to indicate if it's a Rule, Definition or Chore.
  • Link the PR to any issue it solves. This will be done automatically by referencing the issue at the top of this comment in the indicated place.
  • Optionally request feedback from anyone in particular by assigning them as "Reviewers".

When merging a PR:

  • Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

@CLAassistant
Copy link

CLAassistant commented Jan 17, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 6 committers have signed the CLA.

✅ giacomo-petri
❌ Carlos Duarte
❌ Jym77
❌ carlosapaduarte
❌ dependabot[bot]
❌ WilcoFiers


Carlos Duarte seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

giacomo-petri and others added 21 commits January 17, 2023 12:37
giacomo-petri and others added 26 commits February 9, 2023 12:30
…and-context-serve-equivalent-purpose-patch-1
…cal-names-and-context-serve-equivalent-purpose-patch-1
…and-context-serve-equivalent-purpose-patch-1
…and-context-serve-equivalent-purpose-patch-1
…and-context-serve-equivalent-purpose-patch-1
…and-context-serve-equivalent-purpose-patch-1
…and-context-serve-equivalent-purpose-patch-1
…and-context-serve-equivalent-purpose-patch-1
…and-context-serve-equivalent-purpose-patch-1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants