forked from act-rules/act-rules.github.io
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Links with identical accessible names and context serve equivalent purpose rule #4
Open
giacomo-petri
wants to merge
55
commits into
develop
Choose a base branch
from
giacomo-petri-links-with-identical-names-and-context-serve-equivalent-purpose-patch-1
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cal-names-and-context-serve-equivalent-purpose-patch-1
Carlos Duarte seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Co-authored-by: Carlos Duarte <[email protected]>
Co-authored-by: Jean-Yves Moyen <[email protected]>
…-purpose-fd3a94.md Co-authored-by: Jean-Yves Moyen <[email protected]>
Co-authored-by: Carlos Duarte <[email protected]>
…-purpose-fd3a94.md Co-authored-by: Carlos Duarte <[email protected]>
Co-authored-by: Jean-Yves Moyen <[email protected]>
…-purpose-fd3a94.md Co-authored-by: Jean-Yves Moyen <[email protected]>
…and-context-serve-equivalent-purpose-patch-1
…e-fd3a94.md fix typo
…e-fd3a94.md fix typo
…-purpose-fd3a94.md Co-authored-by: Jean-Yves Moyen <[email protected]>
…cal-names-and-context-serve-equivalent-purpose-patch-1
…and-context-serve-equivalent-purpose-patch-1
…-purpose-fd3a94.md Co-authored-by: Wilco Fiers <[email protected]>
…and-context-serve-equivalent-purpose-patch-1
…and-context-serve-equivalent-purpose-patch-1
…and-context-serve-equivalent-purpose-patch-1
…and-context-serve-equivalent-purpose-patch-1
…-purpose-fd3a94.md Co-authored-by: Jean-Yves Moyen <[email protected]>
…-purpose-fd3a94.md Co-authored-by: Jean-Yves Moyen <[email protected]>
…-purpose-fd3a94.md Co-authored-by: Jean-Yves Moyen <[email protected]>
…and-context-serve-equivalent-purpose-patch-1
…and-context-serve-equivalent-purpose-patch-1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current failed scenarios are ambiguous to users in general. With this changes I've updated failed scenarios, providing a clear visual context for sighted users, that doesn't reflect in an equal semantic context for AT users. I've also created an inapplicable example to highlight a scenario which is ambiguous to users in general.
Closes issue(s):
Need for Call for Review:
This will require a 2 weeks Call for Review
I'm note sure about the timing here as multiple failed cases have been updated. I've set 2 weeks but feel free to update if needed.
Pull Request Etiquette
When creating PR:
develop
branch (left side).After creating PR:
Rule
,Definition
orChore
.When merging a PR:
How to Review And Approve