New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button element should have type="button" attribute #11

Closed

aaronlsilber opened this issue Jan 28, 2016 · 1 comment

aaronlsilber commented Jan 28, 2016

Many ASP.net sites have a form element wrapping the entire body (I'm looking at you Kentico).

The button element used to show overflow navigation triggers a page refresh on these sites without a type attribute set to 'button'.

navDropdownToggle.setAttribute("type", "button");

I'd put this on line 192 to fix the issue.

The text was updated successfully, but these errors were encountered:

gijsroge added a commit that referenced this issue


          Added type button to dropdown button. #11

278f708

Owner

gijsroge commented Jan 30, 2016

Thanks for the suggestion! Should be added now.

gijsroge closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment