Skip to content

Commit 3536340

Browse files
committed
fix newly found eslint problems
1 parent e1a405e commit 3536340

File tree

6 files changed

+11
-14
lines changed

6 files changed

+11
-14
lines changed

.eslintrc.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,8 @@ module.exports = {
9696
"jest/globals": true
9797
},
9898
globals: {
99-
nsObj: false
99+
nsObj: false,
100+
jasmine: false
100101
}
101102
}
102103
]

lib/FlagDependencyUsagePlugin.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,10 @@ class FlagDependencyUsagePlugin {
206206
referencedExports === EXPORTS_OBJECT_REFERENCED
207207
) {
208208
map.set(module, referencedExports);
209-
} else if (oldReferencedExports === NO_EXPORTS_REFERENCED) {
209+
} else if (
210+
oldReferencedExports !== undefined &&
211+
referencedExports === NO_EXPORTS_REFERENCED
212+
) {
210213
continue;
211214
} else {
212215
let exportsMap;

lib/RuntimeTemplate.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -606,8 +606,6 @@ class RuntimeTemplate {
606606
* @param {string} options.importVar name of the import variable
607607
* @param {Module} options.originModule module in which the statement is emitted
608608
* @param {boolean=} options.weak true, if this is a weak dependency
609-
* @param {RuntimeSpec=} options.runtime runtime for which this code will be generated
610-
* @param {RuntimeSpec | boolean=} options.runtimeCondition only execute the statement in some runtimes
611609
* @param {Set<string>} options.runtimeRequirements if set, will be filled with runtime requirements
612610
* @returns {[string, string]} the import statement and the compat statement
613611
*/

lib/hmr/HotModuleReplacement.runtime.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ module.exports = function () {
3333
var currentUpdateApplyHandlers;
3434
var queuedInvalidatedModules;
3535

36+
// eslint-disable-next-line no-unused-vars
3637
$hmrModuleData$ = currentModuleData;
3738

3839
$interceptModuleExecution$.push(function (options) {

lib/serialization/FileMiddleware.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,8 @@ class FileMiddleware extends SerializerMiddleware {
233233
* @param {Object} context context object
234234
* @returns {SerializedType|Promise<SerializedType>} serialized data
235235
*/
236-
serialize(data, { filename, extension = "" }) {
236+
serialize(data, context) {
237+
const { filename, extension = "" } = context;
237238
return new Promise((resolve, reject) => {
238239
mkdirp(this.fs, dirname(this.fs, filename), err => {
239240
if (err) return reject(err);
@@ -301,7 +302,8 @@ class FileMiddleware extends SerializerMiddleware {
301302
* @param {Object} context context object
302303
* @returns {DeserializedType|Promise<DeserializedType>} deserialized data
303304
*/
304-
deserialize(data, { filename, extension = "" }) {
305+
deserialize(data, context) {
306+
const { filename, extension = "" } = context;
305307
const readFile = name =>
306308
new Promise((resolve, reject) => {
307309
const file = name

types.d.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -8299,14 +8299,6 @@ declare abstract class RuntimeTemplate {
82998299
* true, if this is a weak dependency
83008300
*/
83018301
weak?: boolean;
8302-
/**
8303-
* runtime for which this code will be generated
8304-
*/
8305-
runtime?: string | SortableSet<string>;
8306-
/**
8307-
* only execute the statement in some runtimes
8308-
*/
8309-
runtimeCondition?: string | boolean | SortableSet<string>;
83108302
/**
83118303
* if set, will be filled with runtime requirements
83128304
*/

0 commit comments

Comments
 (0)