Fix branch name retrieval and ensure final snapshot is stored for the last processed commit

Author: andrew

lib/git/pkgs/commands/init.rb

@@ -17,6 +17,9 @@ def initialize(args)
         def run
           repo = Repository.new
 
+          branch_name = @options[:branch] || repo.default_branch
+          error "Branch '#{branch_name}' not found" unless repo.branch_exists?(branch_name)
+
           if Database.exists?(repo.git_dir) && !@options[:force]
             puts "Database already exists. Use --force to rebuild."
             return
@@ -27,9 +30,6 @@ def run
           Database.create_schema(with_indexes: false)
           Database.optimize_for_bulk_writes
 
-          branch_name = @options[:branch] || repo.default_branch
-          error "Branch '#{branch_name}' not found" unless repo.branch_exists?(branch_name)
-
           branch = Models::Branch.find_or_create(branch_name)
           analyzer = Analyzer.new(repo)
 
@@ -73,6 +73,7 @@ def bulk_process_commits(commits, branch, analyzer, total)
           dependency_commit_count = 0
           snapshots_stored = 0
           processed = 0
+          last_processed_sha = nil
 
           flush = lambda do
             return if pending_commits.empty?
@@ -160,6 +161,8 @@ def bulk_process_commits(commits, branch, analyzer, total)
               position: processed
             }
 
+            last_processed_sha = rugged_commit.oid
+
             if has_changes
               dependency_commit_count += 1
 
@@ -206,13 +209,12 @@ def bulk_process_commits(commits, branch, analyzer, total)
             flush.call if pending_commits.size >= BATCH_SIZE
           end
 
-          # Always store final snapshot for HEAD
-          if snapshot.any?
-            last_sha = commits.last&.oid
-            if last_sha && !pending_snapshots.any? { |s| s[:sha] == last_sha }
+          # Always store final snapshot for the last processed commit
+          if snapshot.any? && last_processed_sha
+            unless pending_snapshots.any? { |s| s[:sha] == last_processed_sha }
               snapshot.each do |(manifest_path, name), dep_info|
                 pending_snapshots << {
-                  sha: last_sha,
+                  sha: last_processed_sha,
                   manifest_path: manifest_path,
                   name: name,
                   ecosystem: dep_info[:ecosystem],

test/git/pkgs/test_cli.rb

@@ -745,6 +745,94 @@ def capture_stdout
   end
 end
 
+class Git::Pkgs::TestInfoCommand < Minitest::Test
+  include TestHelpers
+
+  def setup
+    create_test_repo
+    add_file("Gemfile", "source 'https://rubygems.org'\ngem 'rails'")
+    commit("Add rails")
+    @git_dir = File.join(@test_dir, ".git")
+    Git::Pkgs::Database.connect(@git_dir)
+    Git::Pkgs::Database.create_schema
+  end
+
+  def teardown
+    cleanup_test_repo
+  end
+
+  def test_info_with_zero_snapshots_does_not_crash
+    # Create commits with dependency changes but no snapshots
+    sha = SecureRandom.hex(20)
+    Git::Pkgs::Models::Commit.create!(
+      sha: sha,
+      message: "Test commit",
+      author_name: "Test User",
+      author_email: "[email protected]",
+      committed_at: Time.now,
+      has_dependency_changes: true
+    )
+
+    # Should not raise FloatDomainError
+    output = capture_stdout do
+      Dir.chdir(@test_dir) do
+        Git::Pkgs::Commands::Info.new([]).run
+      end
+    end
+
+    assert_includes output, "Commits with dependency changes: 1"
+    assert_includes output, "Commits with snapshots: 0"
+    assert_includes output, "Coverage: 0.0%"
+    refute_includes output, "1 snapshot per"
+  end
+
+  def test_info_with_snapshots_shows_ratio
+    sha = SecureRandom.hex(20)
+    commit = Git::Pkgs::Models::Commit.create!(
+      sha: sha,
+      message: "Test commit",
+      author_name: "Test User",
+      author_email: "[email protected]",
+      committed_at: Time.now,
+      has_dependency_changes: true
+    )
+
+    manifest = Git::Pkgs::Models::Manifest.create!(
+      path: "Gemfile",
+      ecosystem: "rubygems",
+      kind: "manifest"
+    )
+
+    Git::Pkgs::Models::DependencySnapshot.create!(
+      commit: commit,
+      manifest: manifest,
+      name: "rails",
+      ecosystem: "rubygems",
+      requirement: ">= 0",
+      dependency_type: "runtime"
+    )
+
+    output = capture_stdout do
+      Dir.chdir(@test_dir) do
+        Git::Pkgs::Commands::Info.new([]).run
+      end
+    end
+
+    assert_includes output, "Commits with dependency changes: 1"
+    assert_includes output, "Commits with snapshots: 1"
+    assert_includes output, "Coverage: 100.0%"
+  end
+
+  def capture_stdout
+    original = $stdout
+    $stdout = StringIO.new
+    yield
+    $stdout.string
+  ensure
+    $stdout = original
+  end
+end
+
 class Git::Pkgs::TestSchemaCommand < Minitest::Test
   include TestHelpers