🔨 Maintenance/type checker repo-wide (ITISFoundation#3450)

Author: pcrespov

.github/workflows/ci-testing-deploy.yml

@@ -912,7 +912,10 @@ jobs:
         run: ./ci/helpers/show_system_versions.bash
       - name: install
         run: ./ci/github/unit-testing/postgres-database.bash install
+      - name: typecheck
+        run: ./ci/github/unit-testing/postgres-database.bash typecheck
       - name: test
+        if: always()
         run: ./ci/github/unit-testing/postgres-database.bash test
       - uses: codecov/[email protected]
         with:

ci/github/unit-testing/api-server.bash

@@ -24,6 +24,12 @@ test() {
   popd
 }
 
+typecheck() {
+  pushd services/api-server
+  make mypy
+  popd
+}
+
 # Check if the function exists (bash specific)
 if declare -f "$1" >/dev/null; then
   # call arguments verbatim

ci/github/unit-testing/api.bash

@@ -1,14 +1,14 @@
 #!/bin/bash
 # http://redsymbol.net/articles/unofficial-bash-strict-mode/
-set -o errexit   # abort on nonzero exitstatus
-set -o nounset   # abort on unbound variable
-set -o pipefail  # don't hide errors within pipes
+set -o errexit  # abort on nonzero exitstatus
+set -o nounset  # abort on unbound variable
+set -o pipefail # don't hide errors within pipes
 IFS=$'\n\t'
 
 install() {
-    bash ci/helpers/ensure_python_pip.bash
-    pip3 install --requirement api/tests/requirements.txt
-    pip list --verbose
+  bash ci/helpers/ensure_python_pip.bash
+  pip3 install --requirement api/tests/requirements.txt
+  pip list --verbose
 }
 
 test() {
@@ -23,8 +23,7 @@ test() {
 }
 
 # Check if the function exists (bash specific)
-if declare -f "$1" > /dev/null
-then
+if declare -f "$1" >/dev/null; then
   # call arguments verbatim
   "$@"
 else

ci/github/unit-testing/autoscaling.bash

@@ -24,6 +24,12 @@ test() {
   popd
 }
 
+typecheck() {
+  pushd services/autoscaling
+  make mypy
+  popd
+}
+
 # Check if the function exists (bash specific)
 if declare -f "$1" >/dev/null; then
   # call arguments verbatim

ci/github/unit-testing/catalog.bash

@@ -24,6 +24,12 @@ test() {
   popd
 }
 
+typecheck() {
+  pushd services/catalog
+  make mypy
+  popd
+}
+
 # Check if the function exists (bash specific)
 if declare -f "$1" >/dev/null; then
   # call arguments verbatim

ci/github/unit-testing/dask-sidecar.bash

@@ -24,6 +24,12 @@ test() {
   popd
 }
 
+typecheck() {
+  pushd services/dask-sidecar
+  make mypy
+  popd
+}
+
 # Check if the function exists (bash specific)
 if declare -f "$1" >/dev/null; then
   # call arguments verbatim

ci/github/unit-testing/dask-task-models-library.bash

@@ -32,6 +32,12 @@ test() {
   popd
 }
 
+typecheck() {
+  pushd packages/dask-task-models-library
+  make mypy
+  popd
+}
+
 # Check if the function exists (bash specific)
 if declare -f "$1" >/dev/null; then
   # call arguments verbatim

ci/github/unit-testing/datcore-adapter.bash

@@ -24,6 +24,12 @@ test() {
   popd
 }
 
+typecheck() {
+  pushd services/datcore-adapter
+  make mypy
+  popd
+}
+
 # Check if the function exists (bash specific)
 if declare -f "$1" >/dev/null; then
   # call arguments verbatim

ci/github/unit-testing/director-v2.bash

@@ -27,6 +27,12 @@ test() {
   popd
 }
 
+typecheck() {
+  pushd services/director-v2
+  make mypy
+  popd
+}
+
 # Check if the function exists (bash specific)
 if declare -f "$1" >/dev/null; then
   # call arguments verbatim

ci/github/unit-testing/dynamic-sidecar.bash

@@ -32,6 +32,12 @@ test() {
   popd
 }
 
+typecheck() {
+  pushd services/dynamic-sidecar
+  make mypy
+  popd
+}
+
 # Check if the function exists (bash specific)
 if declare -f "$1" >/dev/null; then
   # call arguments verbatim