Skip to content

Commit 87e02da

Browse files
committed
Use metainf-services annotation processor to generate all service files
1 parent acff8c4 commit 87e02da

File tree

46 files changed

+122
-20
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

46 files changed

+122
-20
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ This project adheres to [Semantic Versioning](http://semver.org/).
66
#### Fixed
77
#### Changed
88
- [fathom-core] Update to SLF4j 1.7.14
9+
- Use `org.kohsuke.metainf-services:meta-services` annotation processor to automatically generate all META-INF/services files
910
#### Added
1011
#### Removed
1112

fathom-eventbus/pom.xml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,13 @@
3232
<artifactId>fathom-core</artifactId>
3333
<version>${project.version}</version>
3434
</dependency>
35+
36+
<dependency>
37+
<groupId>org.kohsuke.metainf-services</groupId>
38+
<artifactId>metainf-services</artifactId>
39+
<scope>provided</scope>
40+
</dependency>
41+
3542
</dependencies>
3643

3744
</project>

fathom-eventbus/src/main/java/fathom/eventbus/EventBusModule.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717

1818
import com.google.common.eventbus.EventBus;
1919
import fathom.Module;
20+
import org.kohsuke.MetaInfServices;
2021
import org.slf4j.Logger;
2122
import org.slf4j.LoggerFactory;
2223

@@ -25,6 +26,7 @@
2526
*
2627
* @author James Moger
2728
*/
29+
@MetaInfServices
2830
public final class EventBusModule extends Module {
2931

3032
private static final Logger log = LoggerFactory.getLogger(EventBusModule.class);

fathom-eventbus/src/main/resources/META-INF/services/fathom.Module

Lines changed: 0 additions & 1 deletion
This file was deleted.

fathom-jcache/pom.xml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,11 @@
3737
<artifactId>cache-annotations-ri-guice</artifactId>
3838
<version>1.0.0</version>
3939
</dependency>
40+
<dependency>
41+
<groupId>org.kohsuke.metainf-services</groupId>
42+
<artifactId>metainf-services</artifactId>
43+
<scope>provided</scope>
44+
</dependency>
4045
<dependency>
4146
<groupId>com.gitblit.fathom</groupId>
4247
<artifactId>fathom-test-tools</artifactId>

fathom-jcache/src/main/java/fathom/jcache/JCacheModule.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
import org.jsr107.ri.annotations.guice.CacheRemoveAllInterceptor;
3030
import org.jsr107.ri.annotations.guice.CacheRemoveEntryInterceptor;
3131
import org.jsr107.ri.annotations.guice.CacheResultInterceptor;
32+
import org.kohsuke.MetaInfServices;
3233
import org.slf4j.Logger;
3334
import org.slf4j.LoggerFactory;
3435

@@ -53,6 +54,7 @@
5354
*
5455
* @author James Moger
5556
*/
57+
@MetaInfServices
5658
public final class JCacheModule extends Module {
5759

5860
private static final Logger log = LoggerFactory.getLogger(JCacheModule.class);

fathom-jcache/src/main/resources/META-INF/services/fathom.Module

Lines changed: 0 additions & 1 deletion
This file was deleted.

fathom-jmx/pom.xml

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,8 @@
1515
~ limitations under the License.
1616
-->
1717

18-
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
18+
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
19+
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
1920
<parent>
2021
<artifactId>fathom-parent</artifactId>
2122
<groupId>com.gitblit.fathom</groupId>
@@ -32,11 +33,16 @@
3233
<artifactId>fathom-core</artifactId>
3334
<version>${project.version}</version>
3435
</dependency>
35-
<dependency>
36-
<groupId>com.j256.simplejmx</groupId>
37-
<artifactId>simplejmx</artifactId>
38-
<version>1.12</version>
39-
</dependency>
36+
<dependency>
37+
<groupId>org.kohsuke.metainf-services</groupId>
38+
<artifactId>metainf-services</artifactId>
39+
<scope>provided</scope>
40+
</dependency>
41+
<dependency>
42+
<groupId>com.j256.simplejmx</groupId>
43+
<artifactId>simplejmx</artifactId>
44+
<version>1.12</version>
45+
</dependency>
4046
</dependencies>
4147

4248
</project>

fathom-jmx/src/main/java/fathom/jmx/JmxModule.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,14 @@
1616
package fathom.jmx;
1717

1818
import fathom.Module;
19+
import org.kohsuke.MetaInfServices;
1920

2021
/**
2122
* Fathom module which binds a JMX server.
2223
*
2324
* @author James Moger
2425
*/
26+
@MetaInfServices
2527
public final class JmxModule extends Module {
2628

2729
@Override

fathom-jmx/src/main/resources/META-INF/services/fathom.Module

Lines changed: 0 additions & 1 deletion
This file was deleted.

fathom-mailer/pom.xml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,11 @@
5050
</exclusion>
5151
</exclusions>
5252
</dependency>
53+
<dependency>
54+
<groupId>org.kohsuke.metainf-services</groupId>
55+
<artifactId>metainf-services</artifactId>
56+
<scope>provided</scope>
57+
</dependency>
5358
<dependency>
5459
<groupId>com.icegreen</groupId>
5560
<artifactId>greenmail</artifactId>

fathom-mailer/src/main/java/fathom/mailer/MailModule.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
package fathom.mailer;
1818

1919
import fathom.Module;
20+
import org.kohsuke.MetaInfServices;
2021
import org.sonatype.micromailer.EMailer;
2122
import org.sonatype.micromailer.MailComposer;
2223
import org.sonatype.micromailer.MailSender;
@@ -29,6 +30,7 @@
2930
/**
3031
* @author James Moger
3132
*/
33+
@MetaInfServices
3234
public class MailModule extends Module {
3335

3436
@Override

fathom-mailer/src/main/resources/META-INF/services/fathom.Module

Lines changed: 0 additions & 1 deletion
This file was deleted.

fathom-metrics-ganglia/pom.xml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,11 @@
3838
<artifactId>metrics-ganglia</artifactId>
3939
<version>3.1.1</version>
4040
</dependency>
41+
<dependency>
42+
<groupId>org.kohsuke.metainf-services</groupId>
43+
<artifactId>metainf-services</artifactId>
44+
<scope>provided</scope>
45+
</dependency>
4146
</dependencies>
4247

4348
</project>

fathom-metrics-ganglia/src/main/java/fathom/metrics/ganglia/Reporter.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
import fathom.metrics.MetricsReporter;
2222
import info.ganglia.gmetric4j.gmetric.GMetric;
2323
import info.ganglia.gmetric4j.gmetric.GMetric.UDPAddressingMode;
24+
import org.kohsuke.MetaInfServices;
2425
import org.slf4j.Logger;
2526
import org.slf4j.LoggerFactory;
2627

@@ -32,6 +33,7 @@
3233
*
3334
* @author James Moger
3435
*/
36+
@MetaInfServices
3537
public class Reporter implements MetricsReporter {
3638

3739
private final Logger log = LoggerFactory.getLogger(Reporter.class);

fathom-metrics-graphite/pom.xml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,11 @@
3838
<artifactId>metrics-graphite</artifactId>
3939
<version>3.1.1</version>
4040
</dependency>
41+
<dependency>
42+
<groupId>org.kohsuke.metainf-services</groupId>
43+
<artifactId>metainf-services</artifactId>
44+
<scope>provided</scope>
45+
</dependency>
4146
</dependencies>
4247

4348
</project>

fathom-metrics-graphite/src/main/java/fathom/metrics/graphite/Reporter.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
import com.codahale.metrics.graphite.PickledGraphite;
2424
import fathom.conf.Settings;
2525
import fathom.metrics.MetricsReporter;
26+
import org.kohsuke.MetaInfServices;
2627
import org.slf4j.Logger;
2728
import org.slf4j.LoggerFactory;
2829

@@ -35,6 +36,7 @@
3536
*
3637
* @author James Moger
3738
*/
39+
@MetaInfServices
3840
public class Reporter implements MetricsReporter {
3941

4042
private final Logger log = LoggerFactory.getLogger(Reporter.class);

fathom-metrics-graphite/src/main/resources/META-INF/services/fathom.metrics.MetricsReporter

Lines changed: 0 additions & 1 deletion
This file was deleted.

fathom-metrics-influxdb/pom.xml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,11 @@
4242
<artifactId>metrics-influxdb</artifactId>
4343
<version>${influxdb.version}</version>
4444
</dependency>
45+
<dependency>
46+
<groupId>org.kohsuke.metainf-services</groupId>
47+
<artifactId>metainf-services</artifactId>
48+
<scope>provided</scope>
49+
</dependency>
4550
</dependencies>
4651

4752
</project>

fathom-metrics-influxdb/src/main/java/fathom/metrics/influxdb/Reporter.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
import fathom.metrics.MetricsReporter;
2222
import metrics_influxdb.InfluxdbHttp;
2323
import metrics_influxdb.InfluxdbReporter;
24+
import org.kohsuke.MetaInfServices;
2425
import org.slf4j.Logger;
2526
import org.slf4j.LoggerFactory;
2627

@@ -32,6 +33,7 @@
3233
*
3334
* @author James Moger
3435
*/
36+
@MetaInfServices
3537
public class Reporter implements MetricsReporter {
3638

3739
private final Logger log = LoggerFactory.getLogger(Reporter.class);

fathom-metrics-influxdb/src/main/resources/META-INF/services/fathom.metrics.MetricsReporter

Lines changed: 0 additions & 1 deletion
This file was deleted.

fathom-metrics-librato/pom.xml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,11 @@
4242
<artifactId>metrics-librato</artifactId>
4343
<version>${librato.version}</version>
4444
</dependency>
45+
<dependency>
46+
<groupId>org.kohsuke.metainf-services</groupId>
47+
<artifactId>metainf-services</artifactId>
48+
<scope>provided</scope>
49+
</dependency>
4550
</dependencies>
4651

4752
</project>

fathom-metrics-librato/src/main/java/fathom/metrics/librato/Reporter.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
import com.librato.metrics.LibratoReporter;
2020
import fathom.conf.Settings;
2121
import fathom.metrics.MetricsReporter;
22+
import org.kohsuke.MetaInfServices;
2223
import org.slf4j.Logger;
2324
import org.slf4j.LoggerFactory;
2425

@@ -30,6 +31,7 @@
3031
*
3132
* @author James Moger
3233
*/
34+
@MetaInfServices
3335
public class Reporter implements MetricsReporter {
3436

3537
private final Logger log = LoggerFactory.getLogger(Reporter.class);

fathom-metrics-librato/src/main/resources/META-INF/services/fathom.metrics.MetricsReporter

Lines changed: 0 additions & 1 deletion
This file was deleted.

fathom-metrics/pom.xml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,12 @@
4343
<artifactId>metrics-jvm</artifactId>
4444
<version>3.1.1</version>
4545
</dependency>
46+
47+
<dependency>
48+
<groupId>org.kohsuke.metainf-services</groupId>
49+
<artifactId>metainf-services</artifactId>
50+
<scope>provided</scope>
51+
</dependency>
4652
</dependencies>
4753

4854
</project>

fathom-metrics/src/main/java/fathom/metrics/MetricsModule.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717

1818
import com.codahale.metrics.MetricRegistry;
1919
import fathom.Module;
20+
import org.kohsuke.MetaInfServices;
2021

2122
import static com.google.inject.matcher.Matchers.annotatedWith;
2223
import static com.google.inject.matcher.Matchers.any;
@@ -26,6 +27,7 @@
2627
*
2728
* @author James Moger
2829
*/
30+
@MetaInfServices
2931
public final class MetricsModule extends Module {
3032

3133
@Override

fathom-metrics/src/main/resources/META-INF/services/fathom.Module

Lines changed: 0 additions & 1 deletion
This file was deleted.

fathom-quartz/pom.xml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,11 @@
4848
<artifactId>quartz-jobs</artifactId>
4949
<version>${quartz.version}</version>
5050
</dependency>
51+
<dependency>
52+
<groupId>org.kohsuke.metainf-services</groupId>
53+
<artifactId>metainf-services</artifactId>
54+
<scope>provided</scope>
55+
</dependency>
5156
<dependency>
5257
<groupId>com.gitblit.fathom</groupId>
5358
<artifactId>fathom-test-tools</artifactId>

fathom-quartz/src/main/java/fathom/quartz/QuartzModule.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,15 @@
1818
import com.google.common.base.Optional;
1919
import fathom.Module;
2020
import fathom.utils.ClassUtil;
21+
import org.kohsuke.MetaInfServices;
2122
import org.slf4j.Logger;
2223
import org.slf4j.LoggerFactory;
2324

2425
/**
2526
* Fathom module for Quartz.
2627
* This module auto-loads the JobsModule and registers the Quartz service.
2728
*/
29+
@MetaInfServices
2830
public class QuartzModule extends Module {
2931

3032
private static final Logger log = LoggerFactory.getLogger(QuartzModule.class);

fathom-quartz/src/main/resources/META-INF/services/fathom.Module

Lines changed: 0 additions & 1 deletion
This file was deleted.

fathom-rest-security/pom.xml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,11 @@
3737
<artifactId>fathom-security</artifactId>
3838
<version>${project.version}</version>
3939
</dependency>
40+
<dependency>
41+
<groupId>org.kohsuke.metainf-services</groupId>
42+
<artifactId>metainf-services</artifactId>
43+
<scope>provided</scope>
44+
</dependency>
4045
</dependencies>
4146

4247
</project>

fathom-rest-security/src/main/java/fathom/rest/security/SecurityModule.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,12 +35,14 @@
3535
import fathom.rest.security.aop.RequireToken;
3636
import fathom.rest.security.aop.RequireTokenInterceptor;
3737
import fathom.security.SecurityManager;
38+
import org.kohsuke.MetaInfServices;
3839

3940
import static com.google.inject.matcher.Matchers.*;
4041

4142
/**
4243
* @author James Moger
4344
*/
45+
@MetaInfServices
4446
public class SecurityModule extends Module {
4547

4648
@Override

fathom-rest-security/src/main/resources/META-INF/services/fathom.Module

Lines changed: 0 additions & 1 deletion
This file was deleted.

fathom-rest-shiro/pom.xml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,11 @@
5151
<artifactId>shiro-web</artifactId>
5252
<version>${shiro.version}</version>
5353
</dependency>
54+
<dependency>
55+
<groupId>org.kohsuke.metainf-services</groupId>
56+
<artifactId>metainf-services</artifactId>
57+
<scope>provided</scope>
58+
</dependency>
5459
<dependency>
5560
<groupId>com.gitblit.fathom</groupId>
5661
<artifactId>fathom-test-tools</artifactId>

fathom-rest-shiro/src/main/java/fathom/shiro/ShiroModule.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,13 +25,15 @@
2525
import org.apache.shiro.web.env.IniWebEnvironment;
2626
import org.apache.shiro.web.env.WebEnvironment;
2727
import org.apache.shiro.web.mgt.WebSecurityManager;
28+
import org.kohsuke.MetaInfServices;
2829

2930

3031
/**
3132
* Simple auth module based on Apache Shiro Core.
3233
*
3334
* @author James Moger
3435
*/
36+
@MetaInfServices
3537
public class ShiroModule extends ServletsModule {
3638

3739
@Override

0 commit comments

Comments
 (0)