`line_shift` is not recalculated when hunk is split in `PathRanges::add`

[jonathantanmy2]

This is most directly visible in tests like https://github.com/gitbutlerapp/gitbutler/blob/master/crates/but-hunk-dependency/src/ranges/tests/path.rs#L139 , where a 7-line hunk was split by an overlapping hunk from a child commit, but the line_shift values weren't recalculated (as far as I can tell, they should be 3 and 3 instead of 7 and 7). When used to shift other stacks when combining path ranges in combine_path_ranges in crates/but-hunk-dependency/src/ranges/mod.rs, this results in incorrect results.

I've created a PR #11368 that demonstrates this issue.

[Byron]

Thanks a lot!

Does this mean #11368 could be used to fix the issue? It seems like this issue text could be part of the PR or a commit even that applies the fix.

And looking at the PR, I think that's the plan:

Currently, this PR just has a demonstration of a bug. Once I've confirmed my understanding of the situation, I'll update this PR to contain a fix.

Sorry for the reasoning text here, I think I was confused by the issue and PR being separate even though the issue would help in understanding the PR.