Skip to content

Commit 3501d95

Browse files
committed
sequencer: remove unnecessary variable setting
revs.pretty_given is only ever read in builtin/log.c, and nothing from builtin/log.c is ever called from sequencer.c. So setting this variable cannot do anything. Remove it. This was introduced in commit 62db524 ("rebase -i: generate the script via rebase--helper", 2017-07-14), which, although `git rev-list` was in use at the time the commit message talks about how the logic had been based on `git log`. Because of this, I am guessing this line was copied or ported from part of builtin/log.c without recognizing that this line was not doing anything and could be removed. It's certainly not doing anything now, though, so remove it. Signed-off-by: Elijah Newren <[email protected]>
1 parent 1a8a497 commit 3501d95

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

sequencer.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6086,7 +6086,6 @@ int sequencer_make_script(struct repository *r, struct strbuf *out, int argc,
60866086
revs.sort_order = REV_SORT_IN_GRAPH_ORDER;
60876087
revs.topo_order = 1;
60886088

6089-
revs.pretty_given = 1;
60906089
git_config_get_string("rebase.instructionFormat", &format);
60916090
if (!format || !*format) {
60926091
free(format);

0 commit comments

Comments
 (0)