Skip to content

Commit 36f4f61

Browse files
committed
adding fix for variable mismatch type
1 parent 377d2a2 commit 36f4f61

File tree

3 files changed

+5
-10
lines changed

3 files changed

+5
-10
lines changed

lambdas/functions/control-plane/src/scale-runners/scale-up.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -255,8 +255,7 @@ export async function scaleUp(eventSource: string, payload: ActionRequestMessage
255255
const onDemandFailoverOnError = process.env.ENABLE_ON_DEMAND_FAILOVER_FOR_ERRORS
256256
? (JSON.parse(process.env.ENABLE_ON_DEMAND_FAILOVER_FOR_ERRORS) as [string])
257257
: [];
258-
const ssmParameterStoreTags: { Key: string; Value: string }[] =
259-
process.env.SSM_PARAMETER_STORE_TAGS && process.env.SSM_PARAMETER_STORE_TAGS.trim() !== ''
258+
const ssmParameterStoreTags: { Key: string; Value: string }[] = process.env.SSM_PARAMETER_STORE_TAGS && process.env.SSM_PARAMETER_STORE_TAGS.trim() !== ''
260259
? JSON.parse(process.env.SSM_PARAMETER_STORE_TAGS)
261260
: [];
262261

@@ -476,7 +475,6 @@ async function createJitConfig(githubRunnerConfig: CreateGitHubRunnerConfig, ins
476475
logger.debug('Runner JIT config for ephemeral runner generated.', {
477476
instance: instance,
478477
});
479-
const tags = [{ Key: 'InstanceId', Value: instance }]
480478
await putParameter(`${githubRunnerConfig.ssmTokenPath}/${instance}`, runnerConfig.data.encoded_jit_config, true, {
481479
tags: [
482480
{ Key: 'InstanceId', Value: instance },

modules/runners/local.tf

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
locals {
2-
parameter_store_tags = [
3-
for k, v in var.parameter_store_tags : {
4-
Key = k
5-
Value = v
6-
}
7-
]
2+
parameter_store_tags = "[${join(", ", [
3+
for key, value in var.parameter_store_tags : "{ key = \"${key}\", value = \"${value}\" }"
4+
])}]"
85
}

modules/runners/pool/variables.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ variable "config" {
1616
timeout = number
1717
zip = string
1818
subnet_ids = list(string)
19-
parameter_store_tags = map(string)
19+
parameter_store_tags = string
2020
})
2121
tags = map(string)
2222
ghes = object({

0 commit comments

Comments
 (0)