Merge pull request #814 from fjatWbyT/exclude-rvaluerefs-a7-1-1

Exclude rvalue references from `const` in AUTOSAR rule 7-1-1.

Author: lcartey

change_notes/2024-12-10-udpate-a7-1-1.md

@@ -0,0 +1,2 @@
+- `A7-1-1` - `DeclarationUnmodifiedObjectMissingConstSpecifier.ql`:
+  - Exclude rvalue references.

cpp/autosar/src/rules/A7-1-1/DeclarationUnmodifiedObjectMissingConstSpecifier.ql

@@ -38,6 +38,7 @@ where
   not exists(LambdaExpression lc | lc.getACapture().getField() = v) and
   not v.isFromUninstantiatedTemplate(_) and
   not v.isCompilerGenerated() and
+  not v.getType() instanceof RValueReferenceType and
   //if the instantiation is not constexpr but the template is, still exclude it as a candidate
   not exists(TemplateVariable b | b.getAnInstantiation() = v and b.isConstexpr())
 select v, "Non-constant variable " + v.getName() + cond + " and is not modified."

cpp/autosar/test/rules/A7-1-1/test.cpp

@@ -83,4 +83,16 @@ template <bool... Args> extern constexpr bool recurse_var = true; // COMPLIANT
 template <bool B1, bool... Args>
 extern constexpr bool recurse_var<B1, Args...> = B1 &&recurse_var<Args...>;
 
-void fp_621() { recurse_var<true, true, true>; }
+void fp_621() { recurse_var<true, true, true>; }
+
+#include <utility>
+
+void variadic_forwarding() {}
+
+template <typename T, typename... Args>
+void variadic_forwarding(T &&first, Args &&...rest) {
+  first;
+  variadic_forwarding(std::forward<Args>(rest)...);
+}
+
+int test_variadic_forwarding() { variadic_forwarding(1, 1.1, "a"); }