Merge pull request #21426 from owen-mc/cpp/validate-constructor-summary-models

C++: Add model validation for constructor summary models

Author: owen-mc

cpp/ql/lib/semmle/code/cpp/dataflow/ExternalFlow.qll

@@ -353,12 +353,26 @@ module CsvValidation {
     )
   }
 
+  private string getIncorrectConstructorSummaryOutput() {
+    exists(string namespace, string type, string name, string output |
+      type = name or
+      type = name + "<" + any(string s)
+    |
+      summaryModel(namespace, type, _, name, _, _, _, output, _, _, _) and
+      output.matches("ReturnValue%") and
+      result =
+        "Constructor model for " + namespace + "." + type +
+          " should use `Argument[this]` in the output, not `ReturnValue`."
+    )
+  }
+
   /** Holds if some row in a CSV-based flow model appears to contain typos. */
   query predicate invalidModelRow(string msg) {
     msg =
       [
         getInvalidModelSignature(), getInvalidModelInput(), getInvalidModelOutput(),
-        getInvalidModelSubtype(), getInvalidModelColumnCount(), KindVal::getInvalidModelKind()
+        getInvalidModelSubtype(), getInvalidModelColumnCount(), KindVal::getInvalidModelKind(),
+        getIncorrectConstructorSummaryOutput()
       ]
   }
 }

csharp/ql/lib/semmle/code/csharp/dataflow/internal/ExternalFlow.qll

@@ -239,7 +239,7 @@ module ModelValidation {
     )
   }
 
-  string getIncorrectConstructorSummaryOutput() {
+  private string getIncorrectConstructorSummaryOutput() {
     exists(string namespace, string type, string name, string output |
       type = name or
       type = name + "<" + any(string s)

java/ql/lib/semmle/code/java/dataflow/ExternalFlow.qll

@@ -367,7 +367,7 @@ module ModelValidation {
     )
   }
 
-  string getIncorrectConstructorSummaryOutput() {
+  private string getIncorrectConstructorSummaryOutput() {
     exists(string namespace, string type, string name, string output |
       summaryModel(namespace, type, _, name, _, _, _, output, _, _, _)
     |