Clean up charpred of WithStatement

joefarebrother · joefarebrother · commit 3d08e52f1fe7 · 2025-03-20T14:18:45.000Z
diff --git a/python/ql/src/Resources/FileNotAlwaysClosedQuery.qll b/python/ql/src/Resources/FileNotAlwaysClosedQuery.qll
@@ -72,9 +72,7 @@ class OsCloseCall extends FileClose {
 
 /** A `with` statement. */
 class WithStatement extends FileClose {
-  With w;
-
-  WithStatement() { this.asExpr() = w.getContextExpr() }
+  WithStatement() { this.asExpr() = any(With w).getContextExpr() }
 }
 
 /** Holds if an exception may be raised at `raises` if `file` is a file object. */

Original file line number	Diff line number	Diff line change
`@@ -72,9 +72,7 @@ class OsCloseCall extends FileClose {`
`72`	`72`
`73`	`73`	/** A `with` statement. */
`74`	`74`	`class WithStatement extends FileClose {`
`75`		`- With w;`
`76`		`-`
`77`		`- WithStatement() { this.asExpr() = w.getContextExpr() }`
	`75`	`+ WithStatement() { this.asExpr() = any(With w).getContextExpr() }`
`78`	`76`	`}`
`79`	`77`
`80`	`78`	/** Holds if an exception may be raised at `raises` if `file` is a file object. */