Skip to content

Commit 627654c

Browse files
committed
Cfg: A few more review tweaks.
1 parent ab94524 commit 627654c

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

shared/controlflow/codeql/controlflow/ControlFlowGraph.qll

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -459,6 +459,9 @@ module Make0<LocationSig Location, AstSig<Location> Ast> {
459459
private predicate propagatesValue(AstNode child, AstNode parent) {
460460
Input1::propagatesValue(child, parent)
461461
or
462+
// For now, the `not postOrInOrder(parent)` is superfluous, as we don't
463+
// have any short-circuiting post-order expressions yet, but this will
464+
// change once we add support for e.g. C#'s `??=`.
462465
shortCircuiting(parent, _) and
463466
not postOrInOrder(parent) and
464467
parent.(BinaryExpr).getRightOperand() = child
@@ -660,7 +663,7 @@ module Make0<LocationSig Location, AstSig<Location> Ast> {
660663
// `(x || y) ?? z`, the `||` may short-circuit with a known boolean
661664
// value `t`, but it occurs in a nullness conditional context, which
662665
// means that the `t0` has nullness kind. In these cases we check
663-
// whether there is an implication that allows translatiion from `t`
666+
// whether there is an implication that allows translation from `t`
664667
// to `t0`, and if not `t0` is simply unrestricted. If the kinds did
665668
// match, then no translation is needed and we're covered by the
666669
// `this = TAfterValueNode(n, t)` case above.

0 commit comments

Comments
 (0)