Skip to content

Commit 6c291e1

Browse files
authored
Add model for handlePongMessage and update test
1 parent 94fcee5 commit 6c291e1

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

java/ql/lib/ext/org.springframework.web.socket.model.yml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,9 @@ extensions:
88
- ["org.springframework.web.socket", "WebSocketHandler", True, "handleMessage", "", "", "Parameter[0]", "remote", "manual"]
99
- ["org.springframework.web.socket", "WebSocketHandler", True, "handleMessage", "", "", "Parameter[1]", "remote", "manual"]
1010
- ["org.springframework.web.socket", "WebSocketHandler", True, "handleTransportError", "", "", "Parameter[0]", "remote", "manual"]
11-
- ["org.springframework.web.socket.handler", "AbstractWebSocketHandler", True, "handleBinaryMessage", "", "", "Parameter[0]", "remote", "manual"]
12-
- ["org.springframework.web.socket.handler", "AbstractWebSocketHandler", True, "handleBinaryMessage", "", "", "Parameter[1]", "remote", "manual"]
13-
- ["org.springframework.web.socket.handler", "AbstractWebSocketHandler", True, "handleTextMessage", "", "", "Parameter[0]", "remote", "manual"]
14-
- ["org.springframework.web.socket.handler", "AbstractWebSocketHandler", True, "handleTextMessage", "", "", "Parameter[1]", "remote", "manual"]
11+
- ["org.springframework.web.socket.handler", "AbstractWebSocketHandler", True, "handleBinaryMessage", "", "", "Parameter[0..1]", "remote", "manual"]
12+
- ["org.springframework.web.socket.handler", "AbstractWebSocketHandler", True, "handlePongMessage", "", "", "Parameter[0..1]", "remote", "manual"]
13+
- ["org.springframework.web.socket.handler", "AbstractWebSocketHandler", True, "handleTextMessage", "", "", "Parameter[0..1]", "remote", "manual"]
1514
- addsTo:
1615
pack: codeql/java-all
1716
extensible: summaryModel

java/ql/test/library-tests/frameworks/spring/websocket/Test.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
import org.springframework.web.socket.WebSocketMessage;
55
import org.springframework.web.socket.TextMessage;
66
import org.springframework.web.socket.BinaryMessage;
7+
import org.springframework.web.socket.PongMessage;
78
import org.springframework.web.socket.CloseStatus;
89

910

@@ -37,6 +38,12 @@ protected void handleBinaryMessage(WebSocketSession s, BinaryMessage m) {
3738
sink(m); // $hasTaintFlow
3839
}
3940

41+
@Override
42+
protected void handlePongMessage(WebSocketSession s, PongMessage m) {
43+
sink(s); // $hasTaintFlow
44+
sink(m); // $hasTaintFlow
45+
}
46+
4047
@Override
4148
public void afterConnectionEstablished(WebSocketSession s) {
4249
sink(s); // $hasTaintFlow

0 commit comments

Comments
 (0)