More feedback

Author: SteveSandersonMS

nodejs/README.md

@@ -655,9 +655,12 @@ try {
 The SDK can automatically download and manage the Copilot CLI for you. This is useful when you can't rely on the CLI being pre-installed.
 
 ```typescript
+import { homedir } from "node:os";
+import { join } from "node:path";
+
 const client = new CopilotClient({
     acquisition: {
-        downloadDir: "~/.myapp/copilot-cli", // Where to store CLI versions
+        downloadDir: join(homedir(), ".myapp", "copilot-cli"), // Where to store CLI versions
     },
 });
 

nodejs/package.json

@@ -16,7 +16,7 @@
   },
   "type": "module",
   "scripts": {
-    "clean": "rimraf --glob dist *.tgz src/generated",
+    "clean": "rimraf --glob dist *.tgz src/generatedOnBuild",
     "prebuild": "tsx scripts/generate-versions.ts",
     "build": "tsx esbuild-copilotsdk-nodejs.ts",
     "test": "vitest run",

nodejs/test/e2e/acquisition.test.ts

@@ -9,12 +9,6 @@ import { tmpdir, homedir } from "node:os";
 import { CopilotClient } from "../../src/index.js";
 import { acquireCli, PREFERRED_CLI_VERSION } from "../../src/acquisition.js";
 
-/**
- * E2E tests for CLI acquisition.
- * 
- * These tests require network access to download from GitHub Releases.
- * They are skipped in CI environments without network access.
- */
 describe("CLI Acquisition E2E", () => {
     let testDir: string;