Skip to content

Commit 01f894d

Browse files
stevesCopilot
andauthored
Re-do no articles found messaging for accessibility (#61482)
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: steves <54561+steves@users.noreply.github.com>
1 parent d0bc232 commit 01f894d

2 files changed

Lines changed: 8 additions & 5 deletions

File tree

src/fixtures/tests/playwright-rendering.spec.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1399,6 +1399,9 @@ test.describe('LandingArticleGridWithFilter component', () => {
13991399
// Should show "no articles found" message as well
14001400
const noResultsMessage = page.getByTestId('no-articles-message')
14011401
await expect(noResultsMessage).toBeVisible()
1402+
await expect(page.locator('[aria-live="polite"][aria-atomic="true"]')).toHaveText(
1403+
'No articles found matching your criteria.',
1404+
)
14021405
})
14031406

14041407
test('responsive behavior on different screen sizes', async ({ page }) => {

src/landings/components/shared/LandingArticleGridWithFilter.tsx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -294,14 +294,14 @@ export const ArticleGrid = ({
294294
/>
295295
))}
296296
{filteredResults.length === 0 && (
297-
<div
298-
role="status"
299-
className={styles.noArticlesContainer}
300-
data-testid="no-articles-message"
301-
>
297+
<div className={styles.noArticlesContainer} data-testid="no-articles-message">
302298
<p className={styles.noArticlesText}>{t('article_grid.no_articles_found')}</p>
303299
</div>
304300
)}
301+
302+
<div aria-live="polite" aria-atomic="true" className="visually-hidden">
303+
{filteredResults.length === 0 ? t('article_grid.no_articles_found') : ''}
304+
</div>
305305
</div>
306306

307307
{/* Pagination */}

0 commit comments

Comments
 (0)