Remove explicit any types from multiple files (#59576)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: heiskr

eslint.config.ts

@@ -230,15 +230,11 @@ export default [
       'src/content-render/unified/annotate.ts',
       'src/content-render/unified/code-header.ts',
       'src/content-render/unified/copilot-prompt.ts',
-      'src/content-render/unified/heading-links.ts',
       'src/content-render/unified/index.ts',
       'src/content-render/unified/module-types.d.ts',
-      'src/content-render/unified/parse-info-string.ts',
       'src/content-render/unified/rewrite-empty-table-rows.ts',
       'src/content-render/unified/rewrite-for-rowheaders.ts',
       'src/content-render/unified/rewrite-local-links.ts',
-      'src/content-render/unified/rewrite-table-captions.ts',
-      'src/content-render/unified/rewrite-thead-th-scope.ts',
       'src/data-directory/lib/data-directory.ts',
       'src/data-directory/lib/data-schemas/features.ts',
       'src/data-directory/lib/data-schemas/learning-tracks.ts',
@@ -247,12 +243,6 @@ export default [
       'src/dev-toc/generate.ts',
       'src/early-access/scripts/migrate-early-access-product.ts',
       'src/early-access/scripts/what-docs-early-access-branch.ts',
-      'src/events/components/events.ts',
-      'src/events/components/experiments/experiment.ts',
-      'src/events/lib/analyze-comment.ts',
-      'src/events/lib/hydro.ts',
-      'src/events/lib/middleware-errors.ts',
-      'src/events/middleware.ts',
       'src/fixtures/tests/categories-and-subcategory.ts',
       'src/fixtures/tests/glossary.ts',
       'src/fixtures/tests/guides.ts',
@@ -264,19 +254,13 @@ export default [
       'src/frame/components/context/CategoryLandingContext.tsx',
       'src/frame/components/context/MainContext.tsx',
       'src/frame/components/context/TocLandingContext.tsx',
-      'src/frame/components/hooks/useQueryParam.ts',
-      'src/frame/components/ui/BumpLink/BumpLink.tsx',
       'src/frame/lib/create-tree.ts',
       'src/frame/lib/frontmatter.ts',
-      'src/frame/lib/get-remote-json.ts',
       'src/frame/lib/page-data.ts',
       'src/frame/lib/page.ts',
-      'src/frame/lib/read-file-contents.ts',
       'src/frame/lib/read-frontmatter.ts',
-      'src/frame/lib/read-json-file.ts',
       'src/frame/middleware/find-page.ts',
       'src/frame/middleware/resolve-carousels.ts',
-      'src/frame/middleware/set-fastly-surrogate-key.ts',
       'src/frame/tests/page.ts',
       'src/frame/tests/read-frontmatter.ts',
       'src/frame/tests/server.ts',
@@ -300,7 +284,6 @@ export default [
       'src/landings/components/SidebarProduct.tsx',
       'src/landings/pages/home.tsx',
       'src/landings/pages/product.tsx',
-      'src/landings/tests/octicons.test.ts',
       'src/languages/lib/correct-translation-content.ts',
       'src/languages/lib/get-alert-titles.ts',
       'src/languages/lib/render-with-fallback.ts',
@@ -310,12 +293,6 @@ export default [
       'src/links/scripts/check-github-github-links.ts',
       'src/links/scripts/update-internal-links.ts',
       'src/links/tests/extract-links.ts',
-      'src/observability/logger/index.ts',
-      'src/observability/logger/lib/logger-context.ts',
-      'src/observability/logger/lib/to-logfmt.ts',
-      'src/observability/middleware/catch-middleware-error.ts',
-      'src/observability/tests/logger.ts',
-      'src/observability/tests/to-logfmt.test.ts',
       'src/pages/_error.tsx',
       'src/products/tests/get-product-groups.ts',
       'src/redirects/middleware/handle-redirects.ts',
@@ -348,8 +325,6 @@ export default [
       'src/search/scripts/index/utils/indexing-elasticsearch-utils.ts',
       'src/search/scripts/scrape/lib/parse-page-sections-into-records.ts',
       'src/search/tests/topics.ts',
-      'src/shielding/middleware/handle-invalid-query-string-values.ts',
-      'src/shielding/middleware/handle-invalid-query-strings.ts',
       'src/tests/helpers/check-url.ts',
       'src/tests/helpers/e2etest.ts',
       'src/tests/scripts/copy-fixture-data.ts',
@@ -362,18 +337,13 @@ export default [
       'src/types/primer__octicons.d.ts',
       'src/versions/scripts/update-versioning-in-files.ts',
       'src/versions/scripts/use-short-versions.ts',
-      'src/versions/tests/get-applicable-versions.ts',
       'src/webhooks/lib/index.ts',
       'src/webhooks/scripts/webhook.ts',
       'src/workflows/content-changes-table-comment.ts',
-      'src/workflows/enable-automerge.ts',
       'src/workflows/fr-add-docs-reviewers-requests.ts',
       'src/workflows/git-utils.ts',
-      'src/workflows/issue-report.ts',
       'src/workflows/projects.ts',
       'src/workflows/tests/actions-workflows.ts',
-      'src/workflows/unallowed-contributions.ts',
-      'src/workflows/walk-files.ts',
     ],
     rules: {
       '@typescript-eslint/no-explicit-any': 'off',

src/archives/middleware/archived-enterprise-versions.ts

@@ -39,17 +39,16 @@ type ArchivedRedirects = {
 // These files are huge so lazy-load them. But note that the
 // `readJsonFileLazily()` function will, at import-time, check that
 // the path does exist.
-const archivedRedirects: () => ArchivedRedirects = readCompressedJsonFileFallbackLazily(
+const archivedRedirects = readCompressedJsonFileFallbackLazily(
   './src/redirects/lib/static/archived-redirects-from-213-to-217.json',
-)
+) as () => ArchivedRedirects
 
 type ArchivedFrontmatterURLs = {
   [url: string]: string[]
 }
-const archivedFrontmatterValidURLS: () => ArchivedFrontmatterURLs =
-  readCompressedJsonFileFallbackLazily(
-    './src/redirects/lib/static/archived-frontmatter-valid-urls.json',
-  )
+const archivedFrontmatterValidURLS = readCompressedJsonFileFallbackLazily(
+  './src/redirects/lib/static/archived-frontmatter-valid-urls.json',
+) as () => ArchivedFrontmatterURLs
 
 // Combine all the things you need to make sure the response is
 // aggressively cached.
@@ -121,15 +120,15 @@ export default async function archivedEnterpriseVersions(
       return res.redirect(redirectCode, redirectTo)
     }
 
-    const redirectJson = await getRemoteJSON(getProxyPath('redirects.json', requestedVersion), {
+    const redirectJson = (await getRemoteJSON(getProxyPath('redirects.json', requestedVersion), {
       retry: retryConfiguration,
       // This is allowed to be different compared to the other requests
       // we make because downloading the `redirects.json` once is very
       // useful because it caches so well.
       // And, as of 2021 that `redirects.json` is 10MB so it's more likely
       // to time out.
       timeout: { response: 1000 },
-    })
+    })) as Record<string, string>
     if (!req.context) throw new Error('No context on request')
     const [language, withoutLanguage] = splitPathByLanguage(req.path, req.context.userLanguage)
     const newRedirectTo = redirectJson[withoutLanguage]
@@ -180,15 +179,15 @@ export default async function archivedEnterpriseVersions(
     versionSatisfiesRange(requestedVersion, `>${lastVersionWithoutArchivedRedirectsFile}`) &&
     !deprecatedWithFunctionalRedirects.includes(requestedVersion)
   ) {
-    const redirectJson = await getRemoteJSON(getProxyPath('redirects.json', requestedVersion), {
+    const redirectJson = (await getRemoteJSON(getProxyPath('redirects.json', requestedVersion), {
       retry: retryConfiguration,
       // This is allowed to be different compared to the other requests
       // we make because downloading the `redirects.json` once is very
       // useful because it caches so well.
       // And, as of 2021 that `redirects.json` is 10MB so it's more likely
       // to time out.
       timeout: { response: 1000 },
-    })
+    })) as Record<string, string>
 
     // make redirects found via redirects.json redirect with a 301
     if (redirectJson[req.path]) {

src/assets/tests/static-assets.ts

@@ -3,7 +3,7 @@ import path from 'path'
 
 import { afterAll, beforeAll, describe, expect, test, vi } from 'vitest'
 import nock from 'nock'
-import type { Response } from 'express'
+import type { Request, Response } from 'express'
 
 import { get } from '@/tests/helpers/e2etest'
 import { checkCachingHeaders } from '@/tests/helpers/caching-headers'
@@ -32,7 +32,7 @@ function mockRequest(requestPath: string, { headers }: { headers?: Record<string
       _headers[header.toLowerCase()] = value
     },
     headers,
-  }
+  } as unknown as Request & ExtendedRequest
 }
 
 type MockResponse = {
@@ -93,7 +93,7 @@ const mockResponse = () => {
     res.statusCode = code
     return res
   }
-  return res
+  return res as unknown as Response & MockResponse
 }
 
 describe('static assets', () => {
@@ -224,11 +224,7 @@ describe('archived enterprise static assets', () => {
       throw new Error('did not expect this to ever happen')
     }
     setDefaultFastlySurrogateKey(req, res, () => {})
-    await archivedEnterpriseVersionsAssets(
-      req as unknown as ExtendedRequest,
-      res as unknown as Response,
-      next,
-    )
+    await archivedEnterpriseVersionsAssets(req, res, next)
     expect(res.statusCode).toBe(200)
     checkCachingHeaders(res, false, 60)
   })
@@ -244,11 +240,7 @@ describe('archived enterprise static assets', () => {
       throw new Error('did not expect this to ever happen')
     }
     setDefaultFastlySurrogateKey(req, res, () => {})
-    await archivedEnterpriseVersionsAssets(
-      req as unknown as ExtendedRequest,
-      res as unknown as Response,
-      next,
-    )
+    await archivedEnterpriseVersionsAssets(req, res, next)
     expect(res.statusCode).toBe(200)
     checkCachingHeaders(res, false, 60)
   })
@@ -264,11 +256,7 @@ describe('archived enterprise static assets', () => {
       throw new Error('did not expect this to ever happen')
     }
     setDefaultFastlySurrogateKey(req, res, () => {})
-    await archivedEnterpriseVersionsAssets(
-      req as unknown as ExtendedRequest,
-      res as unknown as Response,
-      next,
-    )
+    await archivedEnterpriseVersionsAssets(req, res, next)
     expect(res.statusCode).toBe(200)
     checkCachingHeaders(res, false, 60)
   })
@@ -285,11 +273,7 @@ describe('archived enterprise static assets', () => {
       nexted = true
     }
     setDefaultFastlySurrogateKey(req, res, next)
-    await archivedEnterpriseVersionsAssets(
-      req as unknown as ExtendedRequest,
-      res as unknown as Response,
-      next,
-    )
+    await archivedEnterpriseVersionsAssets(req, res, next)
     // It didn't exit in that middleware but called next() to move on
     // with any other middlewares.
     expect(nexted).toBe(true)
@@ -307,11 +291,7 @@ describe('archived enterprise static assets', () => {
       nexted = true
     }
     setDefaultFastlySurrogateKey(req, res, () => {})
-    await archivedEnterpriseVersionsAssets(
-      req as unknown as ExtendedRequest,
-      res as unknown as Response,
-      next,
-    )
+    await archivedEnterpriseVersionsAssets(req, res, next)
     // It tried to go via the proxy, but it wasn't there, but then it
     // tried "our disk" and it's eventually there.
     expect(nexted).toBe(true)
@@ -357,11 +337,7 @@ describe('archived enterprise static assets', () => {
           nexted = true
         }
         setDefaultFastlySurrogateKey(req, res, () => {})
-        await archivedEnterpriseVersionsAssets(
-          req as unknown as ExtendedRequest,
-          res as unknown as Response,
-          next,
-        )
+        await archivedEnterpriseVersionsAssets(req, res, next)
         expect(res.statusCode).toBe(expectStatus)
         if (shouldCallNext) {
           expect(nexted).toBe(true)
@@ -400,11 +376,7 @@ describe('archived enterprise static assets', () => {
           nexted = true
         }
         setDefaultFastlySurrogateKey(req, res, () => {})
-        await archivedEnterpriseVersionsAssets(
-          req as unknown as ExtendedRequest,
-          res as unknown as Response,
-          next,
-        )
+        await archivedEnterpriseVersionsAssets(req, res, next)
         expect(nexted).toBe(shouldCallNext)
         expect(res.statusCode).toBe(expectStatus)
       })

src/audit-logs/lib/index.ts

@@ -158,12 +158,12 @@ export function getAuditLogEvents(page: string, version: string): AuditLogEventT
     auditLogEventsCache.get(openApiVersion)?.set(page, [])
     auditLogEventsCache
       .get(openApiVersion)
-      ?.set(page, readCompressedJsonFileFallback(auditLogFileName))
+      ?.set(page, readCompressedJsonFileFallback(auditLogFileName) as AuditLogEventT[])
   } else if (!auditLogEventsCache.get(openApiVersion)?.has(page)) {
     auditLogEventsCache.get(openApiVersion)?.set(page, [])
     auditLogEventsCache
       .get(openApiVersion)
-      ?.set(page, readCompressedJsonFileFallback(auditLogFileName))
+      ?.set(page, readCompressedJsonFileFallback(auditLogFileName) as AuditLogEventT[])
   }
 
   const auditLogEvents = auditLogEventsCache.get(openApiVersion)?.get(page)

src/content-render/unified/heading-links.ts

@@ -1,27 +1,25 @@
 import { visit } from 'unist-util-visit'
 import { h } from 'hastscript'
+import type { Root, Element, ElementContent, Properties } from 'hast'
 
-interface HeadingNode {
-  type: 'element'
-  tagName: string
-  properties: {
-    id?: string
+interface HeadingNode extends Element {
+  properties: Properties & {
+    id: string
     tabIndex?: number
-    [key: string]: any
   }
-  children: any[]
 }
 
-const matcher = (node: any): node is HeadingNode =>
+const matcher = (node: Element): node is HeadingNode =>
   node.type === 'element' &&
   ['h1', 'h2', 'h3', 'h4', 'h5', 'h6'].includes(node.tagName) &&
-  node.properties?.id
+  !!node.properties?.id
 
 export default function headingLinks() {
-  return (tree: any) => {
-    visit(tree, matcher, (node: HeadingNode) => {
+  return (tree: Root) => {
+    visit(tree, 'element', (node: Element) => {
+      if (!matcher(node)) return
       const { id } = node.properties
-      const text = node.children
+      const text = node.children as ElementContent[]
       node.properties.tabIndex = -1
       node.children = [
         h('a', { className: 'heading-link', href: `#${id}` }, [

src/content-render/unified/parse-info-string.ts

@@ -7,23 +7,21 @@
 // Also parse equals signs, where id=some-id becomes { id: 'some-id' }
 
 import { visit } from 'unist-util-visit'
+import type { Node } from 'unist'
 
-interface CodeNode {
+interface CodeNode extends Node {
   type: 'code'
   lang?: string
   meta?: string | Record<string, string | boolean>
   value: string
 }
 
-// Note: Using 'any' for node because unist-util-visit's type constraints
-// don't easily allow for proper code node typing without complex generics
-const matcher = (node: any): node is CodeNode => node.type === 'code' && node.lang
+const matcher = (node: Node): node is CodeNode => node.type === 'code' && !!(node as CodeNode).lang
 
 export default function parseInfoString() {
-  // Note: Using 'any' for tree because unified's AST types are complex and
-  // this function works with different tree types depending on the processor
-  return (tree: any) => {
-    visit(tree, matcher, (node: CodeNode) => {
+  return (tree: Node) => {
+    visit(tree, 'code', (node: Node) => {
+      if (!matcher(node)) return
       node.meta = strToObj(node.meta as string)
 
       // Temporary, remove {:copy} to avoid highlight parse error in translations.

src/content-render/unified/rewrite-table-captions.ts

@@ -1,6 +1,6 @@
 import { visit } from 'unist-util-visit'
 import type { Node, Parent } from 'unist'
-import type { Element } from 'hast'
+import type { Element, Text } from 'hast'
 
 /**
  * A rehype plugin that automatically adds aria-labelledby attributes to tables
@@ -96,7 +96,7 @@ function findPrecedingHeading(parent: Parent, tableIndex: number): HeadingInfo |
 
 function extractTextFromNode(node: Node): string {
   if (node.type === 'text') {
-    return (node as any).value
+    return (node as Text).value
   }
 
   if (node.type === 'element' && (node as Element).children) {