-
Notifications
You must be signed in to change notification settings - Fork 61k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FUNDING.yml custom links does not include information on valid formats #35690
Comments
Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
This comment was marked as spam.
This comment was marked as spam.
@andrewnicols Thank you for raising this issue! I'll get this triaged for review ✨ Our team will provide feedback regarding the best next steps for this issue - thanks for your patience! 💛 |
Thanks, As @stof has pointed out on composer/composer#12245 the current value is treated as a path due to the lack of scheme. If the value is expected to be manipulated in some way to be useful this needs to be detailed. I assume that if it is missing the scheme then the expectation is that it should be prefixed with |
Thanks for opening an issue! We've triaged this issue for technical review by a subject matter expert 👀 |
This is a gentle bump for the docs team that this issue is waiting for technical review. |
This is a gentle bump for the docs team that this issue is waiting for technical review. |
Code of Conduct
What article on docs.github.com is affected?
https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/displaying-a-sponsor-button-in-your-repository#about-funding-files
What part(s) of the article would you like to see updated?
The sections on Custom URLs do not provide adequate information on the valid formats for a URL.
The following is the entire information:
The example, and the last note suggests that valid custom URL formats include values such as:
octocat.com
octocat.com/example
octocat.com/example/#fund-me
However there is no schema validation to confirm this.
We encountered this as Packagist treats all of the above valid examples as invalid due to the lack of scheme:
composer/composer#12244
Additional information
No response
The text was updated successfully, but these errors were encountered: