Conversation
…grity check
For cross-repo workflow_call invocations, GITHUB_WORKFLOW_REF env var points to
the top-level caller's workflow, not the reusable (callee) workflow. This caused
check_workflow_timestamp_api.cjs to look for lock files in the wrong repository.
The fix injects GH_AW_CONTEXT_WORKFLOW_REF from ${{ github.workflow_ref }} which
correctly identifies the current reusable workflow even in cross-repo scenarios.
Closes #23935
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/536ff9ae-a2dc-4523-923d-77dc878c16ca
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
@copilot ensure in repo and cross repo scenarios are covered by tests. |
…erage Agent-Logs-Url: https://github.com/github/gh-aw/sessions/7e532aa5-50a0-41e2-9fa9-00407921a08e Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Both scenarios are now explicitly covered in Same-repo (
Cross-repo (
|
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/f49e39ad-fc0f-44fc-a75c-4c451342b736 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Fixed in commit f8d58bb. The CI failure was caused by a merge conflict with main branch commit The fix adopts main's updated message in our CJS and updates all 6 test assertions accordingly. |
There was a problem hiding this comment.
Pull request overview
Fixes cross-repo workflow_call lock-file integrity checks by using the reusable workflow’s actual ref (${{ github.workflow_ref }}) rather than the caller workflow’s GITHUB_WORKFLOW_REF, preventing incorrect repo resolution and 404s when fetching lock files.
Changes:
- Inject
GH_AW_CONTEXT_WORKFLOW_REF: "${{ github.workflow_ref }}"into the activation job’s “Check workflow file timestamps” step. - Update
check_workflow_timestamp_api.cjsto preferGH_AW_CONTEXT_WORKFLOW_REF(fallback toGITHUB_WORKFLOW_REF) and log both when available. - Add test coverage for same-repo and cross-repo
workflow_callscenarios; regenerate lock/golden fixtures to include the new env var.
Reviewed changes
Copilot reviewed 188 out of 188 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pkg/workflow/compiler_activation_job.go | Injects GH_AW_CONTEXT_WORKFLOW_REF into the timestamp/hash check step env. |
| actions/setup/js/check_workflow_timestamp_api.cjs | Prefers GH_AW_CONTEXT_WORKFLOW_REF for repo/ref resolution; improves messaging/logging. |
| actions/setup/js/check_workflow_timestamp_api.test.cjs | Adds cross-repo and same-repo workflow_call regression coverage; updates assertions for new messaging. |
| pkg/workflow/testdata/TestWasmGolden_CompileFixtures/with-imports.golden | Golden output regenerated to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| pkg/workflow/testdata/TestWasmGolden_CompileFixtures/basic-copilot.golden | Golden output regenerated to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/workflow-skill-extractor.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/workflow-normalizer.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/workflow-health-manager.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/workflow-generator.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/weekly-safe-outputs-spec-review.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/weekly-issue-summary.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/weekly-editors-health-check.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/weekly-blog-post-writer.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/video-analyzer.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/update-astro.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/unbloat-docs.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/ubuntu-image-analyzer.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/typist.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/tidy.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/test-workflow.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/test-project-url-default.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/test-dispatcher.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/test-create-pr-error-handling.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/terminal-stylist.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/technical-doc-writer.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/super-linter.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/sub-issue-closer.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/step-name-alignment.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/static-analysis-report.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/stale-repo-identifier.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/smoke-workflow-call.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/smoke-workflow-call-with-inputs.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/smoke-update-cross-repo-pr.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/smoke-test-tools.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/smoke-temporary-id.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/smoke-service-ports.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/smoke-project.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/smoke-multi-pr.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/smoke-gemini.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/smoke-create-cross-repo-pr.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/smoke-copilot.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/smoke-copilot-arm.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/smoke-codex.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/smoke-claude.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/smoke-call-workflow.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/smoke-agent-scoped-approved.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/smoke-agent-public-none.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/smoke-agent-public-approved.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/smoke-agent-all-none.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/smoke-agent-all-merged.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/slide-deck-maintainer.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/sergo.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/semantic-function-refactor.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/security-review.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/security-compliance.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/scout.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/schema-feature-coverage.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/schema-consistency-checker.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/safe-output-health.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/research.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/repository-quality-improver.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/repo-tree-map.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/repo-audit-analyzer.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/release.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/refiner.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/q.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/python-data-charts.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/prompt-clustering-analysis.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/pr-triage-agent.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/pr-nitpick-reviewer.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/portfolio-analyst.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/poem-bot.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/plan.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/pdf-summary.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/org-health-report.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/notion-issue-summary.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/metrics-collector.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/mergefest.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/mcp-inspector.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/lockfile-stats.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/layout-spec-maintainer.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/jsweep.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/issue-triage-agent.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/issue-monster.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/issue-arborist.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/instructions-janitor.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/hourly-ci-cleaner.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/grumpy-reviewer.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/gpclean.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/go-pattern-detector.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/go-logger.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/go-fan.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/glossary-maintainer.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/github-remote-mcp-auth-test.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/github-mcp-tools-report.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/github-mcp-structural-analysis.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/functional-pragmatist.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/firewall.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/firewall-escape.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/example-workflow-analyzer.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/example-permissions-warning.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/duplicate-code-detector.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/draft-pr-cleanup.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/docs-noob-tester.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/discussion-task-miner.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/dictation-prompt.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/developer-docs-consolidator.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/dev.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/dev-hawk.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/dependabot-go-checker.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/dependabot-burner.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/delight.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/deep-report.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/dead-code-remover.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/daily-workflow-updater.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/daily-testify-uber-super-expert.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/daily-team-status.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/daily-team-evolution-insights.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/daily-syntax-error-quality.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/daily-semgrep-scan.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/daily-security-red-team.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/daily-secrets-analysis.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/daily-safe-outputs-conformance.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/daily-safe-output-optimizer.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/daily-safe-output-integrator.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/daily-repo-chronicle.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/daily-rendering-scripts-verifier.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/daily-regulatory.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/daily-performance-summary.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/daily-observability-report.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/daily-news.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/daily-multi-device-docs-tester.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/daily-mcp-concurrency-analysis.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/daily-malicious-code-scan.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/daily-issues-report.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/daily-integrity-analysis.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/daily-function-namer.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/daily-firewall-report.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/daily-file-diet.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/daily-fact.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/daily-doc-updater.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/daily-doc-healer.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/daily-copilot-token-report.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/daily-compiler-quality.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/daily-community-attribution.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/daily-code-metrics.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/daily-cli-tools-tester.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/daily-cli-performance.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/daily-choice-test.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/daily-assign-issue-to-user.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/daily-architecture-diagram.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/craft.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/copilot-token-usage-analyzer.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/copilot-token-optimizer.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/copilot-session-insights.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/copilot-pr-prompt-analysis.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/copilot-pr-nlp-analysis.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/copilot-pr-merged-report.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/copilot-cli-deep-research.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/copilot-agent-analysis.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/contribution-check.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/constraint-solving-potd.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/commit-changes-analyzer.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/codex-github-remote-mcp-test.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/code-simplifier.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/code-scanning-fixer.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/cloclo.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/cli-version-checker.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/cli-consistency-checker.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/claude-token-usage-analyzer.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/claude-token-optimizer.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/claude-code-user-docs-review.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/ci-doctor.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/ci-coach.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/changeset.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/breaking-change-checker.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/brave.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/bot-detection.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/blog-auditor.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/auto-triage-issues.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/audit-workflows.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/artifacts-summary.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/archie.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/ai-moderator.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/agentic-observability-kit.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/agent-persona-explorer.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/agent-performance-analyzer.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
| .github/workflows/ace-editor.lock.yml | Regenerated lock workflow to include GH_AW_CONTEXT_WORKFLOW_REF env injection. |
Comments suppressed due to low confidence (1)
actions/setup/js/check_workflow_timestamp_api.cjs:14
- The header comment still says the GitHub API path uses
GITHUB_WORKFLOW_REFto identify the source repo, but the implementation now prefersGH_AW_CONTEXT_WORKFLOW_REF(falling back toGITHUB_WORKFLOW_REF). Please update the docstring bullets to reflect the actual precedence/behavior so readers don’t rely on the wrong variable.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -186,6 +186,11 @@ func (c *Compiler) buildActivationJob(data *WorkflowData, preActivationJobCreate | |||
| steps = append(steps, fmt.Sprintf(" uses: %s\n", GetActionPin("actions/github-script"))) | |||
| steps = append(steps, " env:\n") | |||
| steps = append(steps, fmt.Sprintf(" GH_AW_WORKFLOW_FILE: \"%s\"\n", lockFilename)) | |||
| // Inject the GitHub Actions context workflow_ref expression so that check_workflow_timestamp_api.cjs | |||
There was a problem hiding this comment.
This step is named/commented as a “timestamp” check, but check_workflow_timestamp_api.cjs now performs a frontmatter hash comparison to detect stale lock files. Consider renaming the step (and/or updating the adjacent comment) to match the actual behavior to avoid confusion when reading logs and debugging.
|
@copilot Merge main and recompile |
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/97c9cdb2-7e8e-4562-a922-8158e8054ccf Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Done in commit fb9257d. Merged main (33a0577, c0865b8, 790e8ca, 7122e61, cb732db), resolved conflicts in Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot review comments |
…lock file' Agent-Logs-Url: https://github.com/github/gh-aw/sessions/aebf385c-f9e8-40e7-a40b-bb37f5e548fd Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Done in commit a2b5f44. Renamed the step from Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
When a reusable gh-aw workflow is called cross-repo via
workflow_call, theGITHUB_WORKFLOW_REFenv var always reflects the top-level caller's workflow — not the callee. This causedcheck_workflow_timestamp_api.cjsto resolve the wrong source repo and fail with 404 when fetching the lock file.Root cause
GITHUB_WORKFLOW_REF(env var) ≠${{ github.workflow_ref }}(Actions context):Example failure scenario:
Changes
compiler_activation_job.go: InjectGH_AW_CONTEXT_WORKFLOW_REF: "${{ github.workflow_ref }}"into the "Check workflow lock file" step env. The compiler knows this expression will be evaluated correctly by the Actions runtime. The step is renamed from "Check workflow file timestamps" to "Check workflow lock file" to accurately reflect that it performs a frontmatter hash comparison to detect stale lock files, not a timestamp check.check_workflow_timestamp_api.cjs: PreferGH_AW_CONTEXT_WORKFLOW_REFoverGITHUB_WORKFLOW_REFwhen resolving the source repo and ref. Falls back toGITHUB_WORKFLOW_REFfor backwards compatibility (e.g. older compiled workflows without the new env var). Logs both values whenGH_AW_CONTEXT_WORKFLOW_REFis present.check_workflow_timestamp_api.test.cjs: Two new test suites with full same-repo and cross-repo scenario coverage:cross-repo invocation via workflow_call: correct repo resolution fromGH_AW_CONTEXT_WORKFLOW_REF, cross-repo detection, logging, and fallback toGITHUB_WORKFLOW_REFwhen the new var is absent.same-repo invocation via workflow_call: verifies same-repo detection, hash check, and API ref resolution remain correct whenGH_AW_CONTEXT_WORKFLOW_REFis injected by the compiler.Lock files + golden files: All 183
.lock.ymlfiles and wasm golden files regenerated to include the new env var injection and the renamed step.