Skip to content

[q] feat(design-decision-gate): remove pull request review for design decision gate #25869

@github-actions

Description

@github-actions

Removes the submit-pull-request-review safe-output and all PR review submissions (REQUEST_CHANGES / APPROVE) from the design-decision-gate workflow, as requested in #25830.

Changes

.github/workflows/design-decision-gate.md

  • Removed submit-pull-request-review: max: 1 from safe-outputs frontmatter
  • Removed REQUEST_CHANGES review call in Step 4a (no ADR found — block merge path)
  • Removed APPROVE review call in Step 4b (ADR found and implementation matches path)
  • Removed REQUEST_CHANGES review call in Step 4b (ADR found but divergences path)
  • Updated trailing note from "marked as requesting changes" to reflect comment-only behaviour

Behaviour After Change

The gate now communicates exclusively via PR comments — no PR review state is set. This means:

  • ADR requirements are surfaced via comments, not merge-blocking reviews
  • Passing checks post an informational comment only
  • The push-to-pull-request-branch and add-comment safe-outputs are unchanged

Validation

Compiled successfully: ✅ design-decision-gate


Warning

Protected Files — Push Permission Denied

This was originally intended as a pull request, but the patch modifies protected files. A human must create the pull request manually.

Protected files

The push was rejected because GitHub Actions does not have workflows permission to push these changes, and is never allowed to make such changes, or other authorization being used does not have this permission.

Create the pull request manually
# Download the patch from the workflow run
gh run download 24294767353 -n agent -D /tmp/agent-24294767353

# Create a new branch
git checkout -b q/remove-ddg-pr-review-432df8e9449747de main

# Apply the patch (--3way handles cross-repo patches)
git am --3way /tmp/agent-24294767353/aw-q-remove-ddg-pr-review.patch

# Push the branch and create the pull request
git push origin q/remove-ddg-pr-review-432df8e9449747de
gh pr create --title '[q] feat(design-decision-gate): remove pull request review for design decision gate' --base main --head q/remove-ddg-pr-review-432df8e9449747de --repo github/gh-aw

🎩 Equipped by Q · ● 809.3K ·

  • expires on Apr 14, 2026, 12:23 AM UTC

Metadata

Metadata

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions