Skip to content

[lint-monster] CLI interactive/audit function-length slice #49702

Description

@github-actions

Summary

This lint slice targets the CLI interactive, audit, and entrypoint large-function findings from the current custom lint run. Keep remediation scoped to this slice only.

Findings in this slice

Current count in this slice: 40 shared largefunc findings. Representative diagnostics:

  • pkg/cli/access_log.go:87:6: parseSquidAccessLog is 80 lines long (limit: 60)
  • pkg/cli/actions_build_command.go:202:6: buildAction is 83 lines long (limit: 60)
  • pkg/cli/add_interactive_engine.go:19:32: selectAIEngineAndKey is 118 lines long (limit: 60)
  • pkg/cli/add_interactive_git.go:26:32: createWorkflowPRAndConfigureSecret is 171 lines long (limit: 60)
  • pkg/cli/add_interactive_orchestrator.go:71:6: RunAddInteractive is 126 lines long (limit: 60)
  • pkg/cli/audit_diff.go:67:6: computeFirewallDiff is 144 lines long (limit: 60)

Expected outcome

Reduce this CLI slice by extracting focused helpers and decomposing large command flows without changing command behavior.

Remediation checklist

  • Keep work scoped to findings in this lint group only
  • Prefer minimal, targeted code edits
  • Extract cohesive helpers or split small internal phases rather than rewriting command behavior
  • Preserve behavior and existing tests
  • Validate with make golint-custom before handoff

Fused skill guidance

  • Validate fixes by running make golint-custom.
  • Keep remediation scoped to findings in the assigned lint group.
  • Prefer minimal, targeted code edits.

Copilot instructions

Focus only on CLI interactive/audit/entrypoint files in this issue. Avoid workflow package changes except for imports or tiny helpers strictly required by the chosen CLI slice. Report the exact functions shortened and any remaining largefunc findings in this slice after validation.

Generated by 🧌 LintMonster · gpt54 · 34.8 AIC · ⌖ 5.54 AIC · ⊞ 5.3K ·

  • expires on Aug 8, 2026, 7:47 PM UTC-08:00

Metadata

Metadata

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions