Warn when workflow dispatches share conclusion concurrency by Copilot · Pull Request #55836 · github/gh-aw

Copilot · 2026-08-25T17:45:34Z

workflow_dispatch fan-out silently serializes generated conclusion jobs when concurrency.job-discriminator is omitted, reducing throughput while runs remain green.

Compiler warning
- Warn when a workflow includes workflow_dispatch without a job discriminator.
- Explain that dispatches share one conclusion concurrency group.
- Recommend a per-run discriminator:
```
concurrency:
  job-discriminator: ${{ github.run_id }}
```
Coverage
- Cover dispatch inputs, mixed triggers, configured discriminators, and non-dispatch workflows.

Fixes Warn when a workflow_dispatch workflow has no job-discriminator: the shared conclusion group silently caps fan-out #55813

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 11 AIC · ⌖ 8.12 AIC · ⊞ 8.7K · ◷
_{Comment /souschef to run again}

Run: https://github.com/github/gh-aw/actions/runs/32897609333

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 14.9 AIC · ⌖ 8.16 AIC · ⊞ 8.7K · ◷
_{Comment /souschef to run again}

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 20.8 AIC · ⌖ 8.13 AIC · ⊞ 8.7K · ◷
_{Comment /souschef to run again}

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot

Pull request overview

Adds compiler diagnostics for shared conclusion-job concurrency in manually dispatched workflows.

Changes:

Emits an actionable missing-discriminator warning.
Adds trigger and discriminator test cases.

Show a summary per file

File	Description
`pkg/workflow/compiler_validators.go`	Adds the concurrency warning.
`pkg/workflow/workflow_dispatch_concurrency_warning_test.go`	Tests warning conditions.

Review details

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Files reviewed: 2/2 changed files
Comments generated: 2
Review effort level: Balanced

 }

 func (c *Compiler) emitGeneralToolWarnings(workflowData *WorkflowData, markdownPath string) {
+	if strings.Contains(workflowData.On, "workflow_dispatch") && workflowData.ConcurrencyJobDiscriminator == "" {


 }

 func (c *Compiler) emitGeneralToolWarnings(workflowData *WorkflowData, markdownPath string) {
+	if strings.Contains(workflowData.On, "workflow_dispatch") && workflowData.ConcurrencyJobDiscriminator == "" {


Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

gh-aw-bot · 2026-08-25T20:41:10Z

gh-aw-pr-sous-chef
@copilot PR Sous Chef triage: this PR still needs a forward-progress pass before maintainer investigation is likely to be productive.

Please do one focused follow-up pass:

address the unresolved Copilot review feedback in the existing review threads and push the fixes
refresh the branch if needed and use the pr-finisher skill before handing back for review

Run: https://github.com/github/gh-aw/actions/runs/32896118186

Generated by 👨🍳 PR Sous Chef

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 11 AIC · ⌖ 8.12 AIC · ⊞ 8.7K · ◷
_{Comment /souschef to run again}

…minator

gh-aw-bot · 2026-08-25T20:56:10Z

@copilot PR Sous Chef triage: this PR still needs a forward-progress pass before maintainer investigation is likely to be productive.

Please do one focused follow-up pass:

address the unresolved Copilot review feedback in the existing review threads and push the fixes
refresh the branch if needed and use the pr-finisher skill before handing back for review

Run: https://github.com/github/gh-aw/actions/runs/32897609333

Generated by 👨🍳 PR Sous Chef

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 14.9 AIC · ⌖ 8.16 AIC · ⊞ 8.7K · ◷
_{Comment /souschef to run again}

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot · 2026-08-25T21:02:48Z

gh-aw-pr-sous-chef
@copilot PR Sous Chef triage: this PR still needs a forward-progress pass before maintainer investigation is likely to be productive.
...

Completed the focused follow-up in 51b1f54: the warning now requires configured safe outputs, with a no-safe-outputs regression case. The branch is refreshed from main, and PR-finisher validation passed (make fmt, make lint, make test, make recompile, and the final pre-push gate).

Copilot · 2026-08-25T21:14:25Z

@copilot PR Sous Chef triage: this PR still needs a forward-progress pass before maintainer investigation is likely to be productive.

Please do one focused follow-up pass:...

The unresolved feedback is already implemented on the current HEAD: a478d98 parses top-level workflow_dispatch inputs and covers nested values, while 51b1f54 gates the warning on configured safe outputs and adds the negative regression. The branch is current with the PR base, and the PR-finisher local validation passed. The remaining blocker is marking the three outdated review threads resolved; this environment does not expose a thread-resolution operation.

pelikhan · 2026-08-25T22:30:47Z

@copilot resolve the merge conflicts on this branch.

gh-aw-bot · 2026-08-25T22:55:07Z

gh-aw-pr-sous-chef
@copilot PR Sous Chef triage: this PR has merge conflicts and still needs a forward-progress pass before maintainer investigation is likely to be productive.

Please do one focused follow-up pass:

run make merge-main to resolve the current merge conflicts on this branch
after the conflicts are resolved, rerun the relevant validation and use the pr-finisher skill before handing back for review

Run: https://github.com/github/gh-aw/actions/runs/32907942669

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 14.6 AIC · ⌖ 8.22 AIC · ⊞ 6.3K · ◷
_{Comment /souschef to run again}

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot · 2026-08-25T23:38:55Z

gh-aw-pr-sous-chef
@copilot PR Sous Chef triage: this PR has merge conflicts and still needs a forward-progress pass before maintainer investigation is likely to be productive.
...

Ran make merge-main, resolved the validator conflict, and pushed true merge commit f86eac9. Post-merge lint, unit/full tests, and recompilation pass; all 294 workflows compile.

@copilot resolve the merge conflicts on this branch.

Resolved and pushed in merge commit f86eac9. The conflict retained the dispatch-input warning helper while accepting the upstream bounded-query removal; post-merge lint, unit/full tests, and recompilation pass.

github-actions · 2026-08-26T06:26:52Z

Category: bug | Risk: medium | Score: 55/100 (impact 24/50, urgency 15/30, quality 16/20) | Action: batch_review | Batch: workflow-runtime

Generated by 🔧 PR Triage Agent · copilot · mai10 · 12.3 AIC · ⌖ 2.45 AIC · ⊞ 15.6K · ◷

gh-aw-bot · 2026-08-26T08:49:02Z

gh-aw-pr-sous-chef
@copilot PR Sous Chef triage: this PR still needs a forward-progress pass before maintainer investigation is likely to be productive.

Please do one focused follow-up pass:

refresh the branch if needed and use the pr-finisher skill before handing back for review

Run: https://github.com/github/gh-aw/actions/runs/32949103424

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 20.8 AIC · ⌖ 8.13 AIC · ⊞ 8.7K · ◷
_{Comment /souschef to run again}

…minator

Copilot · 2026-08-26T09:00:43Z

gh-aw-pr-sous-chef
@copilot PR Sous Chef triage: this PR still needs a forward-progress pass before maintainer investigation is likely to be productive.
...

The branch is already refreshed in merge commit b8478f5, whose second parent is the current base d846ab2. PR-finisher validation passes (make fmt, make lint, make test-unit, make test, and make recompile; all 294 workflows compile). The two remaining outdated Copilot threads are implemented but still need to be marked resolved.

github-actions · 2026-08-26T12:29:36Z

Triage update: Category: bug | Risk: medium | Score: 54/100 (impact 24 + urgency 14 + quality 16) | Action: auto_merge | Batch: workflow-runtime

Generated by 🔧 PR Triage Agent · copilot · mai10 · 17.1 AIC · ⌖ 2.78 AIC · ⊞ 15.6K · ◷

github-actions · 2026-08-26T12:29:43Z

Triage update: Category: bug | Risk: medium | Score: 54/100 (impact 24 + urgency 14 + quality 16) | Action: auto_merge | Batch: workflow-runtime

Generated by 🔧 PR Triage Agent · copilot · mai10 · 17.1 AIC · ⌖ 2.78 AIC · ⊞ 15.6K · ◷

Initial plan

8bc4ed4

Copilot AI assigned Copilot and pelikhan Aug 25, 2026

Copilot started work on behalf of pelikhan August 25, 2026 17:45 View session

Copilot AI linked an issue Aug 25, 2026 that may be closed by this pull request

Warn when a workflow_dispatch workflow has no job-discriminator: the shared conclusion group silently caps fan-out #55813

Closed

Warn on shared dispatch conclusion concurrency

b38547c

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Warn when a workflow_dispatch workflow has no job-discriminator~~ Warn when workflow dispatches share conclusion concurrency Aug 25, 2026

Copilot finished work on behalf of pelikhan August 25, 2026 17:57

Copilot AI requested a review from pelikhan August 25, 2026 17:57

github-actions Bot mentioned this pull request Aug 25, 2026

[PR Triage Report] PR triage report: no eligible Copilot PRs due to cooldown #55842

Closed

pelikhan marked this pull request as ready for review August 25, 2026 20:06

Copilot AI balanced review requested due to automatic review settings August 25, 2026 20:06

Copilot started reviewing on behalf of pelikhan August 25, 2026 20:07 View session

pelikhan reviewed Aug 25, 2026

View reviewed changes

Comment thread pkg/workflow/compiler_validators.go Outdated

Copilot AI reviewed Aug 25, 2026

View reviewed changes

Copilot started work on behalf of pelikhan August 25, 2026 20:15 View session

Warn only for dispatches with inputs

a478d98

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot finished work on behalf of pelikhan August 25, 2026 20:26

Copilot AI requested a review from pelikhan August 25, 2026 20:26

Merge branch 'main' into copilot/warn-workflow-dispatch-no-job-discri…

3eff649

…minator

github-actions Bot mentioned this pull request Aug 25, 2026

[pr-sous-chef] PR Sous Chef run report #55546

Closed

Copilot started work on behalf of gh-aw-bot August 25, 2026 20:41 View session

Gate dispatch warning on safe outputs

51b1f54

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot finished work on behalf of gh-aw-bot August 25, 2026 21:03

Copilot AI requested a review from gh-aw-bot August 25, 2026 21:03

Copilot started work on behalf of gh-aw-bot August 25, 2026 21:04 View session

Copilot finished work on behalf of gh-aw-bot August 25, 2026 21:14

Copilot started work on behalf of gh-aw-bot August 25, 2026 22:55 View session

Merge main and resolve validator conflict

f86eac9

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot finished work on behalf of gh-aw-bot August 25, 2026 23:39

github-actions Bot mentioned this pull request Aug 26, 2026

[pr-sous-chef] PR Sous Chef run report #55899

Open

github-actions Bot added pr-action:batch_review pr-agent:copilot pr-batch:workflow-runtime pr-priority:medium pr-risk:medium pr-type:bug labels Aug 26, 2026

github-actions Bot mentioned this pull request Aug 26, 2026

[PR Triage Report] PR triage report: 2026-08-26 #55959

Closed

Merge branch 'main' into copilot/warn-workflow-dispatch-no-job-discri…

b8478f5

…minator

Copilot started work on behalf of gh-aw-bot August 26, 2026 08:49 View session

Copilot finished work on behalf of gh-aw-bot August 26, 2026 09:01

github-actions Bot added the pr-action:auto_merge label Aug 26, 2026

github-actions Bot mentioned this pull request Aug 26, 2026

[PR Triage Report] PR triage report for 2026-08-26T12:24:20Z #56026

Closed

pelikhan merged commit 3b33e84 into main Aug 26, 2026
1 check passed

pelikhan deleted the copilot/warn-workflow-dispatch-no-job-discriminator branch August 26, 2026 14:00

Uh oh!

Conversation

Copilot AI commented Aug 25, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Review details

Uh oh!

gh-aw-bot commented Aug 25, 2026

Uh oh!

gh-aw-bot commented Aug 25, 2026

Uh oh!

Copilot AI commented Aug 25, 2026

Uh oh!

Copilot AI commented Aug 25, 2026

Uh oh!

pelikhan commented Aug 25, 2026

Uh oh!

gh-aw-bot commented Aug 25, 2026

Uh oh!

Copilot AI commented Aug 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 26, 2026

Uh oh!

gh-aw-bot commented Aug 26, 2026

Uh oh!

Copilot AI commented Aug 26, 2026

Uh oh!

github-actions Bot commented Aug 26, 2026

Uh oh!

github-actions Bot commented Aug 26, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Aug 25, 2026 •

edited by github-actions Bot

Loading

Copilot AI commented Aug 25, 2026 •

edited

Loading