fix: correct key type hint, isolate all catalog tests from env

- Fix key parameter type to str | None (defaults to None)
- Add HOME/USERPROFILE monkeypatch and clear SPECKIT_INTEGRATION_CATALOG_URL
  in all TestCatalogFetch tests for full environment isolation

Author: mnriem

src/specify_cli/__init__.py

@@ -2221,7 +2221,7 @@ def integration_switch(
 
 @integration_app.command("upgrade")
 def integration_upgrade(
-    key: str = typer.Argument(None, help="Integration key to upgrade (default: current integration)"),
+    key: str | None = typer.Argument(None, help="Integration key to upgrade (default: current integration)"),
     force: bool = typer.Option(False, "--force", help="Force upgrade even if files are modified"),
     script: str | None = typer.Option(None, "--script", help="Script type: sh or ps (default: from init-options.json or platform default)"),
     integration_options: str | None = typer.Option(None, "--integration-options", help="Options for the integration"),

tests/integrations/test_integration_catalog.py

@@ -76,6 +76,7 @@ class TestActiveCatalogs:
     def test_defaults_when_no_config(self, tmp_path, monkeypatch):
         monkeypatch.setenv("HOME", str(tmp_path))
         monkeypatch.setenv("USERPROFILE", str(tmp_path))
+        monkeypatch.delenv("SPECKIT_INTEGRATION_CATALOG_URL", raising=False)
         (tmp_path / ".specify").mkdir()
         cat = IntegrationCatalog(tmp_path)
         active = cat.get_active_catalogs()
@@ -153,6 +154,9 @@ def fake_urlopen(url, timeout=10):
         monkeypatch.setattr(urllib.request, "urlopen", fake_urlopen)
 
     def test_fetch_and_search_all(self, tmp_path, monkeypatch):
+        monkeypatch.setenv("HOME", str(tmp_path))
+        monkeypatch.setenv("USERPROFILE", str(tmp_path))
+        monkeypatch.delenv("SPECKIT_INTEGRATION_CATALOG_URL", raising=False)
         (tmp_path / ".specify").mkdir()
         cat = IntegrationCatalog(tmp_path)
 
@@ -178,6 +182,9 @@ def test_fetch_and_search_all(self, tmp_path, monkeypatch):
         assert "acme-coder" in ids
 
     def test_search_by_tag(self, tmp_path, monkeypatch):
+        monkeypatch.setenv("HOME", str(tmp_path))
+        monkeypatch.setenv("USERPROFILE", str(tmp_path))
+        monkeypatch.delenv("SPECKIT_INTEGRATION_CATALOG_URL", raising=False)
         (tmp_path / ".specify").mkdir()
         cat = IntegrationCatalog(tmp_path)
 
@@ -195,6 +202,9 @@ def test_search_by_tag(self, tmp_path, monkeypatch):
         assert all("cli" in r.get("tags", []) for r in results)
 
     def test_search_by_query(self, tmp_path, monkeypatch):
+        monkeypatch.setenv("HOME", str(tmp_path))
+        monkeypatch.setenv("USERPROFILE", str(tmp_path))
+        monkeypatch.delenv("SPECKIT_INTEGRATION_CATALOG_URL", raising=False)
         (tmp_path / ".specify").mkdir()
         cat = IntegrationCatalog(tmp_path)
 
@@ -213,6 +223,9 @@ def test_search_by_query(self, tmp_path, monkeypatch):
         assert results[0]["id"] == "claude"
 
     def test_get_integration_info(self, tmp_path, monkeypatch):
+        monkeypatch.setenv("HOME", str(tmp_path))
+        monkeypatch.setenv("USERPROFILE", str(tmp_path))
+        monkeypatch.delenv("SPECKIT_INTEGRATION_CATALOG_URL", raising=False)
         (tmp_path / ".specify").mkdir()
         cat = IntegrationCatalog(tmp_path)
 
@@ -232,6 +245,9 @@ def test_get_integration_info(self, tmp_path, monkeypatch):
         assert cat.get_integration_info("nonexistent") is None
 
     def test_invalid_catalog_format(self, tmp_path, monkeypatch):
+        monkeypatch.setenv("HOME", str(tmp_path))
+        monkeypatch.setenv("USERPROFILE", str(tmp_path))
+        monkeypatch.delenv("SPECKIT_INTEGRATION_CATALOG_URL", raising=False)
         (tmp_path / ".specify").mkdir()
         cat = IntegrationCatalog(tmp_path)