fix(presets): reconcile constitution after removal

When the removed preset supplied constitution-template, rematerialize the
winning remaining resolver layer only if provenance proves the live file is
still generated and unchanged. Preserve edited constitutions and report
post-removal reconciliation failures as non-fatal warnings.

Add coverage for restoring the core layer, falling back from a removed
higher-priority preset, and preserving edited generated content.

Assisted-by: GitHub Copilot (model: GPT-5.6 Sol, autonomous)
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 1b2c095d-b45c-4d52-8d56-bd6121d96ab6

Author: BenBtg

src/specify_cli/presets/__init__.py

@@ -1729,23 +1729,8 @@ def _seed_constitution_from_preset(self, manifest: PresetManifest) -> None:
         if not provides_constitution:
             return
 
-        memory_constitution = (
-            self.project_root / ".specify" / "memory" / "constitution.md"
-        )
         try:
-            resolver = PresetResolver(self.project_root)
-            layers = resolver.collect_all_layers(
-                "constitution-template", "template"
-            )
-            if memory_constitution.exists() and not _constitution_is_generated(
-                self.project_root, memory_constitution, layers
-            ):
-                return
-            result = _materialize_constitution_template(
-                self.project_root, memory_constitution
-            )
-            if result is None:
-                return
+            self._reconcile_constitution()
         except (OSError, UnicodeDecodeError, PresetValidationError, ValueError) as exc:
             import warnings
 
@@ -1754,6 +1739,19 @@ def _seed_constitution_from_preset(self, manifest: PresetManifest) -> None:
                 stacklevel=2,
             )
 
+    def _reconcile_constitution(self) -> None:
+        """Materialize the winning constitution layer when the live file is generated."""
+        memory_constitution = (
+            self.project_root / ".specify" / "memory" / "constitution.md"
+        )
+        resolver = PresetResolver(self.project_root)
+        layers = resolver.collect_all_layers("constitution-template", "template")
+        if memory_constitution.exists() and not _constitution_is_generated(
+            self.project_root, memory_constitution, layers
+        ):
+            return
+        _materialize_constitution_template(self.project_root, memory_constitution)
+
     def install_from_zip(
         self,
         zip_path: Path,
@@ -1833,13 +1831,19 @@ def remove(self, pack_id: str) -> bool:
         # Also include aliases from the manifest as a safety net for registries
         # populated by older versions that may not track aliases.
         removed_cmd_names = set()
+        removed_constitution = False
         for cmd_names in registered_commands.values():
             removed_cmd_names.update(cmd_names)
         manifest_path = pack_dir / "preset.yml"
         if manifest_path.exists():
             try:
                 manifest = PresetManifest(manifest_path)
                 for tmpl in manifest.templates:
+                    if (
+                        tmpl.get("type") == "template"
+                        and tmpl.get("name") == "constitution-template"
+                    ):
+                        removed_constitution = True
                     if tmpl.get("type") == "command":
                         for alias in tmpl.get("aliases", []):
                             if isinstance(alias, str):
@@ -1886,6 +1890,18 @@ def remove(self, pack_id: str) -> bool:
                     stacklevel=2,
                 )
 
+        if removed_constitution:
+            try:
+                self._reconcile_constitution()
+            except (OSError, UnicodeDecodeError, PresetValidationError, ValueError) as exc:
+                import warnings
+
+                warnings.warn(
+                    f"Post-removal constitution reconciliation failed for {pack_id}: "
+                    f"{exc}. The live constitution may be stale.",
+                    stacklevel=2,
+                )
+
         return True
 
     def list_installed(self) -> List[Dict[str, Any]]:

tests/test_presets.py

@@ -2704,6 +2704,24 @@ def test_self_test_removal_restores_core(self, project_dir):
             assert result is not None
             assert result["source"] == "core"
 
+        memory = project_dir / ".specify" / "memory" / "constitution.md"
+        assert memory.read_text() == "# Core constitution-template\n"
+
+    def test_self_test_removal_preserves_edited_constitution(self, project_dir):
+        """Removing a preset does not overwrite an edited generated constitution."""
+        templates_dir = project_dir / ".specify" / "templates"
+        (templates_dir / "constitution-template.md").write_text("# Core Constitution\n")
+
+        manager = PresetManager(project_dir)
+        install_self_test_preset(manager)
+        memory = project_dir / ".specify" / "memory" / "constitution.md"
+        edited = memory.read_text() + "\n## Authored amendment\n"
+        memory.write_text(edited)
+
+        manager.remove("self-test")
+
+        assert memory.read_text() == edited
+
     def test_self_test_not_in_catalog(self):
         """Verify the self-test preset is NOT in the catalog (it's local-only)."""
         catalog_path = Path(__file__).parent.parent / "presets" / "catalog.json"
@@ -2893,10 +2911,10 @@ def test_constitution_seed_composes_wrap_strategy(self, project_dir, temp_dir):
         assert "# Wrapper Constitution" in content
         assert "## Core Principle" in content
 
-    def test_higher_priority_preset_reseeds_unchanged_generated_constitution(
+    def test_constitution_follows_priority_when_winning_preset_removed(
         self, project_dir, temp_dir
     ):
-        """An unchanged generated constitution follows resolver priority."""
+        """An unchanged generated constitution follows priority and fallback layers."""
         manager = PresetManager(project_dir)
         install_self_test_preset(manager)
 
@@ -2936,6 +2954,10 @@ def test_higher_priority_preset_reseeds_unchanged_generated_constitution(
         memory = project_dir / ".specify" / "memory" / "constitution.md"
         assert memory.read_text() == "# Higher Priority Constitution\n"
 
+        manager.remove("higher-priority")
+
+        assert "preset:self-test" in memory.read_text()
+
     def test_constitution_seed_rejects_symlinked_memory_directory(
         self, project_dir, temp_dir
     ):