Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discrepencies vs spec and NodeTemplatePart #43

Open
keithamus opened this issue Jan 10, 2022 · 0 comments
Open

Discrepencies vs spec and NodeTemplatePart #43

keithamus opened this issue Jan 10, 2022 · 0 comments

Comments

@keithamus
Copy link
Member

One other thing I see discrepancy with is missing NodeValueSetter in NodeTemplatePart. I get your reasoning - it also seems a bit faster to not have setter and call splitText in collecting parts instead of initial replacing with collected parts, but I wonder if nodePart.replacementNodes can be useful for processor implementors - it seems to be missing now.

  // NodeTemplatePart
++  get replacementNodes() {
++    return this.#parts
++  }

Originally posted by @dy in #38 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant