Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid eagerly getting "full" commit details for inline blame #4115

Closed
eamodio opened this issue Feb 27, 2025 · 1 comment
Closed

Avoid eagerly getting "full" commit details for inline blame #4115

eamodio opened this issue Feb 27, 2025 · 1 comment
Assignees
Labels
needs-verification Request for verification pending-release Resolved but not yet released to the stable edition
Milestone

Comments

@eamodio
Copy link
Member

eamodio commented Feb 27, 2025

Description

Unless we are in a Live Share, we avoid adding a hover to the inline blame decoration, and instead relay on the on-demand hover provider. But we are still loading the full commit details eagerly for no real reason.

@eamodio eamodio added the triage Needs to be looked at label Feb 27, 2025
@eamodio eamodio added this to the 16.4 milestone Feb 27, 2025
@eamodio eamodio self-assigned this Feb 27, 2025
@eamodio eamodio removed the triage Needs to be looked at label Feb 27, 2025
@github-actions github-actions bot added needs-verification Request for verification pending-release Resolved but not yet released to the stable edition labels Feb 27, 2025
@eamodio eamodio added needs-verification Request for verification and removed needs-verification Request for verification labels Feb 27, 2025
@eamodio
Copy link
Member Author

eamodio commented Feb 27, 2025

While this fix, avoids the eager loading for the inline blame specifically, we will still end up eagerly loading the full commit details if the status bar blame is also enabled. As VS Code doesn't provide a way to delay load status bar hovers. See microsoft/vscode#145096 (though the VS Code team closed it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-verification Request for verification pending-release Resolved but not yet released to the stable edition
Projects
None yet
Development

No branches or pull requests

1 participant