Skip to content

Remove obsolete node labels for ws-daemon and registry-facade readiness #20904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

kylos101
Copy link
Contributor

@kylos101 kylos101 commented Jun 16, 2025

Description

Removes the node labels gitpod.io/ws-daemon_ready_ns_* and gitpod.io/registry-facade_ready_ns_* as they are no longer necessary since workspace scheduling now relies on taints instead of positive labels.

Changes:

  • ws-manager-mk2: Remove NodeSelectorRequirements for obsolete labels
  • node-labeler: Remove label constants and management logic while preserving taint functionality
  • Documentation: Update to reflect taint-based scheduling approach

🤖 Generated with Claude Code

Co-Authored-By: Claude [email protected]

Related Issue(s)

Fixes CLC-1326

How to test

Build a GCP packer image that applies taints on new nodes, but not labels, and assert workspaces can start.

Documentation

Preview status

gitpod:summary

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

Removes the node labels `gitpod.io/ws-daemon_ready_ns_*` and `gitpod.io/registry-facade_ready_ns_*` as they are no longer necessary since workspace scheduling now relies on taints instead of positive labels.

Changes:
- ws-manager-mk2: Remove NodeSelectorRequirements for obsolete labels
- node-labeler: Remove label constants and management logic while preserving taint functionality
- Documentation: Update to reflect taint-based scheduling approach

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants