Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assigning quantifiers may fail, despite "pool requirements met" #142

Open
mattyg opened this issue Mar 7, 2022 · 0 comments
Open

Assigning quantifiers may fail, despite "pool requirements met" #142

mattyg opened this issue Mar 7, 2022 · 0 comments
Labels
api bug Something isn't working dashboard wontfix This will not be worked on

Comments

@mattyg
Copy link
Collaborator

mattyg commented Mar 7, 2022

If the quantifier pool size is near the minimum required quantifier pool size, you can't predict if there will be enough quantifiers, because you don't know the composition of the praise bins. Additionally there are many different ways for the bins to be packed (and some intentional randomness), and thus assignQuantifiersDryRun() doesn't know if there will be enough quantifiers for the bins until it generates the bins.

This presents a UX issue, because a user may see "quantifier pool requirements are met" then have a quantification assignment fail.

Overview

  • The user calls verifyQuantiferPoolSize(), which calls assignQuantifiersDryRun() once.
  • Then the user calls assignQuantifiers() which calls assignQuantifiersDryRun() again.
  • It is possible for the quantifier pool to be sufficient for the first run's bin-packing arrangement, but not for the second run's different bin-packing arrangement.

Options to Resolve

  • Modify the architecture verifyQuantiferPoolSize() and assignQuantifiers() to act like a multi-part form, where the form state is saved between steps
  • Modify verifyQuantiferPoolSize() & AssignDialog component UX to indicate it is only capable of providing an estimate of the number of quantifiers needed. Do not actually run assignQuantifiersDryRun() within verifyQuantiferPoolSize()
@mattyg mattyg added bug Something isn't working api dashboard labels Mar 7, 2022
@mattyg mattyg self-assigned this Apr 5, 2022
@kristoferlund kristoferlund added the wontfix This will not be worked on label May 18, 2022
@kristoferlund kristoferlund moved this to Icebox / future features in Praise Development Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api bug Something isn't working dashboard wontfix This will not be worked on
Projects
Status: Icebox / future features
Development

No branches or pull requests

2 participants