Skip to content

Commit ada439e

Browse files
committed
add a todo about NPE
1 parent afff68a commit ada439e

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

src/com/goide/GoDocumentationProvider.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,13 +39,15 @@
3939
import com.intellij.psi.stubs.StubIndex;
4040
import com.intellij.psi.util.PsiTreeUtil;
4141
import com.intellij.util.Function;
42-
import com.intellij.util.ObjectUtils;
4342
import com.intellij.util.containers.ContainerUtil;
4443
import com.intellij.xml.util.XmlStringUtil;
4544
import org.jetbrains.annotations.NotNull;
4645
import org.jetbrains.annotations.Nullable;
4746

48-
import java.util.*;
47+
import java.util.Arrays;
48+
import java.util.Collections;
49+
import java.util.Comparator;
50+
import java.util.List;
4951

5052
public class GoDocumentationProvider extends AbstractDocumentationProvider {
5153
private static final GoCommentsConverter COMMENTS_CONVERTER = new GoCommentsConverter();
@@ -277,7 +279,7 @@ private static String replaceInnerTypes(@NotNull GoType type, @Nullable String c
277279
private static String replaceInnerTypes(@NotNull GoType type, @Nullable String contextImportPath, @NotNull List<GoType> innerTypes) {
278280
StringBuilder result = new StringBuilder();
279281
String typeText = type.getText();
280-
int initialOffset = ObjectUtils.notNull(type.getTextRange(), TextRange.EMPTY_RANGE).getStartOffset();
282+
int initialOffset = type.getTextRange().getStartOffset(); // todo[zolotov] a potential NPE: type.getTextRange() could be null
281283
int lastStartOffset = type.getTextLength();
282284
ContainerUtil.sort(innerTypes, ELEMENT_BY_RANGE_COMPARATOR);
283285
for (int i = innerTypes.size() - 1; i >= 0; i--) {

0 commit comments

Comments
 (0)