Log build ID in local symbolization error messages. (google#679)

aalexand · web-flow · commit d25a53d42d00 · 2022-01-13T06:42:19.000-08:00
This helps diagnose symbolization issues.
diff --git a/internal/symbolizer/symbolizer.go b/internal/symbolizer/symbolizer.go
@@ -325,6 +325,9 @@ func newMapping(prof *profile.Profile, obj plugin.ObjTool, ui plugin.UI, force b
 		}
 
 		name := filepath.Base(m.File)
+		if m.BuildID != "" {
+			name += fmt.Sprintf(" (build ID %s)", m.BuildID)
+		}
 		f, err := obj.Open(m.File, m.Start, m.Limit, m.Offset)
 		if err != nil {
 			ui.PrintErr("Local symbolization failed for ", name, ": ", err)

Original file line number	Diff line number	Diff line change
`@@ -325,6 +325,9 @@ func newMapping(prof *profile.Profile, obj plugin.ObjTool, ui plugin.UI, force b`
`325`	`325`	`}`
`326`	`326`
`327`	`327`	`name := filepath.Base(m.File)`
	`328`	`+ if m.BuildID != "" {`
	`329`	`+ name += fmt.Sprintf(" (build ID %s)", m.BuildID)`
	`330`	`+ }`
`328`	`331`	`f, err := obj.Open(m.File, m.Start, m.Limit, m.Offset)`
`329`	`332`	`if err != nil {`
`330`	`333`	`ui.PrintErr("Local symbolization failed for ", name, ": ", err)`