decodeJSON will hang

[Khachi-at]

• Test codes as follow:

func TestXxx(t *testing.T) {
	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
		w.Write([]byte("null"))
	}))

	client := resty.New().SetRetryCount(DefaultRetryTimes).EnableGenerateCurlCmd()

	x := map[string]string{}

	resp, err := client.R().SetBody("{}").
		SetHeader("Content-Type", "application/json; charset=utf-8").
		SetForceResponseContentType("application/json").
		SetAllowMethodGetPayload(true).
		SetResponseBodyUnlimitedReads(true).
		SetResult(x).
		Get(server.URL + "/test")

	fmt.Println(err)
	fmt.Println(resp.String())
}

• The decodeJson function will loop infinitely

[Khachi-at]

I think the bug is at there. After reading the body, no write back to r.Body.

[Khachi-at]

The following code can make this bug clearer：

package resty

import (
	"io"
	"strings"
	"testing"
)

func TestDecodeJSON(t *testing.T) {
	r := &Response{
		Body: io.NopCloser(strings.NewReader("null")),
	}
	r.wrapCopyReadCloser()
	err := r.readAll()

	assertNil(t, err)

	var result string
	err = decodeJSON(r.Body, &result)
	assertNil(t, err)
	assertEqual(t, "null", result)
}

[hu-xiaokang]

I think the problem is here: r.r.Seek(0, io.SeekStart). Why do we need to do this?

type nopReadCloser struct {
	r *bytes.Reader
}

func (r *nopReadCloser) Read(p []byte) (int, error) {
	n, err := r.r.Read(p)
	if err == io.EOF {
		r.r.Seek(0, io.SeekStart)
	}
	return n, err
}

[jeevatkm]

Fixed by PR #1002