Switch to Mono.Cecil

Author: goaaats

CheapLoc.Test/TestForm.Designer.cs

@@ -27,5 +27,10 @@ private void Button1_Click(object sender, EventArgs e)
         {
             MessageBox.Show(Loc.Localize("MsgBoxText", "A box! Nice!"));
         }
+
+        private void button2_Click(object sender, EventArgs e)
+        {
+            Loc.ExportLocalizable();
+        }
     }
 }

CheapLoc.Test/TestForm.cs

@@ -1,15 +1,14 @@
 {
-
-  "1": {
-    "Key": "LabelTest",
-    "Message": "Das hier ist ein Test-Label!"
+  "LabelTest": {
+    "message": "Hier ist ein Label.",
+    "description": "TestForm..ctor"
   },
-  "2": {
-    "Key": "ButtonTest",
-    "Message": "Du hast"
+  "ButtonTest": {
+    "message": "Klick mich!",
+    "description": "TestForm..ctor"
   },
-  "3": {
-    "Key": "MsgBoxText",
-    "Message": "Eine Box! Knorke."
+  "MsgBoxText": {
+    "message": "Eine Box! Super!",
+    "description": "TestForm.Button1_Click"
   }
 }

CheapLoc.Test/de_DE.json

@@ -33,6 +33,7 @@
     <DocumentationFile>bin\Release\CheapLoc.xml</DocumentationFile>
   </PropertyGroup>
   <ItemGroup>
+    <PackageReference Include="Mono.Cecil" Version="0.11.3" />
     <PackageReference Include="Newtonsoft.Json" Version="12.0.2" />
   </ItemGroup>
 </Project>

CheapLoc/CheapLoc.csproj

@@ -6,8 +6,9 @@
 using System.Reflection;
 using System.Reflection.Emit;
 using System.Runtime.CompilerServices;
-using Mono.Reflection;
+using Mono.Cecil;
 using Newtonsoft.Json;
+using OpCodes = Mono.Cecil.Cil.OpCodes;
 
 namespace CheapLoc
 {
@@ -106,8 +107,87 @@ public static void ExportLocalizableForAssembly(Assembly assembly)
         {
             var types = assembly.GetTypes();
 
+            var debugOutput = string.Empty;
             var outList = new Dictionary<string, LocEntry>();
 
+            var assemblyDef = AssemblyDefinition.ReadAssembly(assembly.Location);
+
+            var toInspect = assemblyDef.MainModule.GetTypes()
+                .SelectMany(t => t.Methods
+                    .Where(m => m.HasBody)
+                    .Select(m => new {t, m}));
+
+            foreach (var tm in toInspect)
+            {
+                var instructions = tm.m.Body.Instructions;
+
+                foreach (var instruction in instructions)
+                {
+                    if (instruction.OpCode == OpCodes.Call)
+                    {
+                        var methodInfo = instruction.Operand as MethodReference;
+
+                        if (methodInfo != null)
+                        {
+                            var methodType = methodInfo.DeclaringType;
+                            var parameters = methodInfo.Parameters;
+
+                            if (!methodInfo.Name.Contains("Localize"))
+                                continue;
+
+                            debugOutput += string.Format("->{0}.{1}.{2}({3});\n", 
+                                    tm.t.FullName,
+                                    methodType.Name,
+                                    methodInfo.Name,
+                                    string.Join(", ",
+                                        parameters.Select(p =>
+                                            p.ParameterType.FullName + " " + p.Name).ToArray())
+                                );
+
+                            var entry = new LocEntry
+                            {
+                                Message = instruction.Previous.Operand as string,
+                                Description = $"{tm.t.Name}.{tm.m.Name}"
+                            };
+
+                            var key = instruction.Previous.Previous.Operand as string;
+
+                            if (string.IsNullOrEmpty(key))
+                            {
+                                throw new Exception(
+                                    $"Key was empty for message: {entry.Message} (from {entry.Description})");
+                            }
+
+                            if (outList.Any(x => x.Key == key))
+                            {
+                                if (outList.Any(x => x.Key == key && x.Value.Message != entry.Message))
+                                {
+                                    throw new Exception(
+                                        $"Message with key {key} has previous appearance but other fallback text in {entry.Description}");
+                                }
+                            }
+                            else
+                            {
+                                debugOutput += $"    ->{key} - {entry.Message} (from {entry.Description})\n";
+                                outList.Add(key, entry);
+                            }
+                        }
+                    }
+                }
+            }
+
+            File.WriteAllText("loc.log", debugOutput);
+            File.WriteAllText($"{GetAssemblyName(assembly)}_Localizable.json", JsonConvert.SerializeObject(outList,
+                new JsonSerializerSettings
+                {
+                    Formatting = Formatting.Indented
+                }));
+
+            return;
+
+            /*
+            Old version, depended on Mono.Reflection/MethodBaseRocks
+
             foreach (var type in types.Where(x => x.IsClass || x.IsAbstract))
             {
                 var toParse = new List<MethodBase>();
@@ -117,7 +197,7 @@ public static void ExportLocalizableForAssembly(Assembly assembly)
                 foreach (var method in toParse)
                     try
                     {
-                        var instructions = MethodBodyReader.GetInstructions(method);
+                        var instructions = method.GetInstructions();
 
                         foreach (var instruction in instructions)
                             if (instruction.OpCode == OpCodes.Call)
@@ -173,12 +253,7 @@ public static void ExportLocalizableForAssembly(Assembly assembly)
                         Debug.WriteLine($"Couldn't parse {method.Name}:\n{ex}");
                     }
             }
-
-            File.WriteAllText($"{GetAssemblyName(assembly)}_Localizable.json", JsonConvert.SerializeObject(outList,
-                new JsonSerializerSettings
-                {
-                    Formatting = Formatting.Indented
-                }));
+            */
         }
 
         /// <summary>