TESTS: Add routing verb tests.

cypriss · cypriss · commit a8dc8ea8b4cd · 2014-08-31T15:44:25.000-07:00
diff --git a/TODO b/TODO
@@ -4,8 +4,6 @@ TODO:
    - HTTPMethod
    - HTTPMethods
  - Code coverage
-   - setup: Post, Put, Delete, Patch
-   - show errors middleware
    - IsRouted, RoutePath
    - PanicHandler
    - Invalid handlers?
diff --git a/show_errors_middleware_test.go b/show_errors_middleware_test.go
@@ -22,7 +22,7 @@ func TestShowErrorsMiddleware(t *testing.T) {
 	if rw.Code != 500 {
 		t.Errorf("Expected status code 500 but got %d", rw.Code)
 	}
-	
+
 	body := strings.TrimSpace(string(rw.Body.Bytes()))
 	if !strings.HasPrefix(body, "<html>") {
 		t.Errorf("Expected an HTML page but got '%s'", body)
diff --git a/tree_test.go b/tree_test.go
@@ -288,3 +288,40 @@ func TestRoutesWithPrefix(t *testing.T) {
 		}
 	}
 }
+
+func TestRouteVerbs(t *testing.T) {
+	router := New(Context{})
+	router.Get("/a", func(w ResponseWriter, r *Request) {
+		fmt.Fprintf(w, "GET")
+	})
+	router.Put("/a", func(w ResponseWriter, r *Request) {
+		fmt.Fprintf(w, "PUT")
+	})
+	router.Post("/a", func(w ResponseWriter, r *Request) {
+		fmt.Fprintf(w, "POST")
+	})
+	router.Delete("/a", func(w ResponseWriter, r *Request) {
+		fmt.Fprintf(w, "DELETE")
+	})
+	router.Patch("/a", func(w ResponseWriter, r *Request) {
+		fmt.Fprintf(w, "PATCH")
+	})
+
+	for _, method := range HTTPMethods {
+		method := string(method)
+
+		recorder := httptest.NewRecorder()
+		request, _ := http.NewRequest(method, "/a", nil)
+
+		router.ServeHTTP(recorder, request)
+
+		if recorder.Code != 200 {
+			t.Error("Test:", method, " Didn't get Code=200. Got Code=", recorder.Code)
+		}
+
+		body := strings.TrimSpace(string(recorder.Body.Bytes()))
+		if body != method {
+			t.Error("Test:", method, " Didn't get Body=", method, ". Got Body=", body)
+		}
+	}
+}
diff --git a/web_test.go b/web_test.go
@@ -19,6 +19,8 @@ func (l nullPanicReporter) Panic(url string, err interface{}, stack string) {
 	// no op
 }
 func init() {
+	// This disables printing panics to stderr during testing, because that is very noisy,
+	// and we purposefully test some panics.
 	PanicHandler = nullPanicReporter{}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ func TestShowErrorsMiddleware(t *testing.T) {`
`22`	`22`	`if rw.Code != 500 {`
`23`	`23`	`t.Errorf("Expected status code 500 but got %d", rw.Code)`
`24`	`24`	`}`
`25`		`-`
	`25`	`+`
`26`	`26`	`body := strings.TrimSpace(string(rw.Body.Bytes()))`
`27`	`27`	`if !strings.HasPrefix(body, "<html>") {`
`28`	`28`	`t.Errorf("Expected an HTML page but got '%s'", body)`
Original file line number	Diff line number	Diff line change
`@@ -19,6 +19,8 @@ func (l nullPanicReporter) Panic(url string, err interface{}, stack string) {`
`19`	`19`	`// no op`
`20`	`20`	`}`
`21`	`21`	`func init() {`
	`22`	`+ // This disables printing panics to stderr during testing, because that is very noisy,`
	`23`	`+ // and we purposefully test some panics.`
`22`	`24`	`PanicHandler = nullPanicReporter{}`
`23`	`25`	`}`
`24`	`26`