fix gofmt warnings

Author: cynthia.ding@oracle.com

samples/adsclient/go/src/speedle/rest/authz/client/client_test.go

@@ -18,7 +18,7 @@ func TestIsAllowed(t *testing.T) {
 	context := authz.RequestContext{
 		Subject: &authz.Subject{
 			Principals: []*authz.Principal{
-				&authz.Principal{
+				{
 					Type: "user",
 					Name: "alan.cao",
 				},

samples/adsclient/go/src/speedle/rest/authz/client/example/main.go

@@ -21,7 +21,7 @@ func main() {
 	context := authz.RequestContext{
 		Subject: &authz.Subject{
 			Principals: []*authz.Principal{
-				&authz.Principal{
+				{
 					Type: "user",
 					Name: "alan.cao",
 				},

samples/embedded/expenses/speedle_handler.go

@@ -32,7 +32,7 @@ func Wrap(handler http.Handler, service, spdlLoc string) (http.HandlerFunc, erro
 		reqCtx := ads.RequestContext{
 			Subject: &ads.Subject{
 				Principals: []*ads.Principal{
-					&ads.Principal{
+					{
 						Type: "user",
 						Name: user,
 					},

samples/integration/docker-integration/plugin.go

@@ -78,7 +78,7 @@ func (plugin *speedleDockerPlugin) toRequestContext(req *authorization.Request)
 	}
 	subject := authz.Subject{
 		Principals: []*authz.Principal{
-			&authz.Principal{
+			{
 				Type: "user",
 				Name: user,
 			},

samples/integration/kubernetes-integration/webhook.go

@@ -462,7 +462,7 @@ func (impl *handlerImpl) evaluatePolicies(clusterName string, req *v1beta1.Subje
 
 	subject := authz.Subject{
 		Principals: []*authz.Principal{
-			&authz.Principal{
+			{
 				Type: "user",
 				Name: req.Spec.User,
 			},

testutil/cmdTestUtil.go

@@ -60,7 +60,7 @@ func (client *CmdClient) ExecuteCmd(parameter string, data *CmdTestData) error {
 func NewCmdClient() *CmdClient {
 	var cmdStr string
 	binPath := os.Getenv("GOPATH")
-	if strings.Compare(string(binPath[len(binPath)-1:len(binPath)]), "/") != 0 {
+	if strings.Compare(string(binPath[len(binPath)-1:]), "/") != 0 {
 		binPath = binPath + "/"
 	}
 
@@ -80,7 +80,7 @@ func NewCmdClient() *CmdClient {
 func NewCmdClient_token(token string) *CmdClient {
 	var cmdStr string
 	binPath := os.Getenv("GOPATH")
-	if strings.Compare(string(binPath[len(binPath)-1:len(binPath)]), "/") != 0 {
+	if strings.Compare(string(binPath[len(binPath)-1:]), "/") != 0 {
 		binPath = binPath + "/"
 	}
 

testutil/restTestUtil.go

@@ -621,7 +621,7 @@ func GetRestTestData_CreatePolicy(step string, srvName string, policyName string
 				Name:   policyName,
 				Effect: effect,
 				Permissions: []*pmsapi.Permission{
-					&pmsapi.Permission{
+					{
 						Resource: resource,
 						Actions:  actions,
 					},
@@ -633,7 +633,7 @@ func GetRestTestData_CreatePolicy(step string, srvName string, policyName string
 				Name:   policyName,
 				Effect: effect,
 				Permissions: []*pmsapi.Permission{
-					&pmsapi.Permission{
+					{
 						Resource: resource,
 						Actions:  actions,
 					},

testutil/testBase.go

@@ -79,7 +79,7 @@ func RunTestCases(t *testing.T, testcases *[]TestCase, ctx *TestContext) {
 			//If test case name is like sleep_500, then it would sleep 500ms
 			method := strings.ToLower(tc.Method)
 			if strings.Contains(method, "sleep") {
-				sleep, _ := strconv.Atoi(method[6:len(method)])
+				sleep, _ := strconv.Atoi(method[6:])
 				t.Logf("Sleep %d mill-secondes", sleep)
 				time.Sleep(time.Duration(sleep) * time.Millisecond)
 				continue

testutil/testUtil.go

@@ -592,7 +592,7 @@ func postGetAllGrantedPermissions_rest(outputBody interface{}, expectedBody inte
 
 		res := make([]string, len(*outputPerms))
 		j := 0
-		for k, _ := range adjustMap {
+		for k := range adjustMap {
 			res[j] = k
 			j++
 		}