Merge pull request #1857 from qqwobble/silenced-warning-call-with-variant

Silenced compiler warning in godot::call_with_variant_args_ret_helper

Author: dsnopek

include/godot_cpp/core/binder_common.hpp

@@ -261,6 +261,7 @@ void call_with_variant_args_ret_helper(T *p_instance, R (T::*p_method)(P...), co
 #else
 	r_ret = (p_instance->*p_method)(VariantCaster<P>::cast(*p_args[Is])...);
 #endif
+	(void)p_args; // Avoid warning.
 }
 
 template <typename T, typename R, typename... P, size_t... Is>
@@ -272,7 +273,7 @@ void call_with_variant_args_retc_helper(T *p_instance, R (T::*p_method)(P...) co
 #else
 	r_ret = (p_instance->*p_method)(VariantCaster<P>::cast(*p_args[Is])...);
 #endif
-	(void)p_args;
+	(void)p_args; // Avoid warning.
 }
 
 template <typename T, typename... P>

include/godot_cpp/core/class_db.hpp

@@ -46,9 +46,9 @@
 
 #include <godot_cpp/templates/local_vector.hpp>
 
+#include <godot_cpp/templates/hash_set.hpp>
 #include <list>
 #include <mutex>
-#include <set>
 #include <unordered_map>
 
 // Needed to use StringName as key in `std::unordered_map`
@@ -96,10 +96,10 @@ class ClassDB {
 		StringName parent_name;
 		GDExtensionInitializationLevel level = GDEXTENSION_INITIALIZATION_SCENE;
 		std::unordered_map<StringName, MethodBind *> method_map;
-		std::set<StringName> signal_names;
+		HashSet<StringName> signal_names;
 		std::unordered_map<StringName, VirtualMethod> virtual_methods;
-		std::set<StringName> property_names;
-		std::set<StringName> constant_names;
+		HashSet<StringName> property_names;
+		HashSet<StringName> constant_names;
 		// Pointer to the parent custom class, if any. Will be null if the parent class is a Godot class.
 		ClassInfo *parent_ptr = nullptr;
 	};

src/core/class_db.cpp

@@ -410,7 +410,7 @@ void ClassDB::initialize(GDExtensionInitializationLevel p_level) {
 }
 
 void ClassDB::deinitialize(GDExtensionInitializationLevel p_level) {
-	std::set<StringName> to_erase;
+	HashSet<StringName> to_erase;
 	for (int i = class_register_order.size() - 1; i >= 0; --i) {
 		const StringName &name = class_register_order[i];
 		const ClassInfo &cl = classes[name];