Skip to content

Conversation

@dsnopek
Copy link
Contributor

@dsnopek dsnopek commented Dec 3, 2025

This is a follow-up to #113282

That PR changed the argument names in the .cpp files, but not the .h files. This updates the .h files to match!

Since it's only changing the names in the headers files, it shouldn't carry any risk. (But sorry for the extra churn!)

@dsnopek dsnopek added this to the 4.x milestone Dec 3, 2025
@dsnopek dsnopek requested review from a team as code owners December 3, 2025 10:20
@dsnopek dsnopek added the bug label Dec 3, 2025
@dsnopek dsnopek requested a review from a team as a code owner December 3, 2025 10:20
Copy link
Member

@Ivorforce Ivorforce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main reason I think the parameter name prefixes should match across the files is that it makes it slightly easier to global-search the function signature.
Otherwise, I don't feel very strongly about this.

@Repiteo Repiteo modified the milestones: 4.x, 4.6 Dec 3, 2025
@akien-mga akien-mga merged commit 04107df into godotengine:master Dec 3, 2025
20 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants