Refactor command arguments for security

unknwon · web-flow · commit 1c4fb1985a1f · 2025-11-18T23:13:33.000-05:00
diff --git a/repo_tag.go b/repo_tag.go
@@ -249,9 +249,7 @@ func (r *Repository) CreateTag(name, rev string, opts ...CreateTagOptions) error
 		}
 		cmd.AddArgs("--end-of-options")
 	} else {
-		// 🚨 SECURITY: Prevent including unintended options in the path to the Git command.
-		cmd.AddArgs("--end-of-options")
-		cmd.AddArgs(name)
+		cmd.AddArgs("--end-of-options", name)
 	}
 
 	cmd.AddArgs(rev)

Original file line number	Diff line number	Diff line change
`@@ -249,9 +249,7 @@ func (r *Repository) CreateTag(name, rev string, opts ...CreateTagOptions) error`
`249`	`249`	`}`
`250`	`250`	`cmd.AddArgs("--end-of-options")`
`251`	`251`	`} else {`
`252`		`- // 🚨 SECURITY: Prevent including unintended options in the path to the Git command.`
`253`		`- cmd.AddArgs("--end-of-options")`
`254`		`- cmd.AddArgs(name)`
	`252`	`+ cmd.AddArgs("--end-of-options", name)`
`255`	`253`	`}`
`256`	`254`
`257`	`255`	`cmd.AddArgs(rev)`