Skip to content

x/website: unify playground.js location #32007

Open
@bradfitz

Description

@bradfitz
Contributor

We currently have two copies of the playground's playground.js: one in x/tools (the original) and one in x/website (the new home, but currently unused?).

Unify.

/cc @ysmolsky @andybons @dmitshur @katiehockman @cnoellekb

Activity

added this to the Unreleased milestone on May 13, 2019
andybons

andybons commented on May 13, 2019

@andybons
Member

The one in x/website is used by the playground widget on golang.org.

added
NeedsFixThe path to resolution is known, but the work has not been done.
on May 13, 2019
self-assigned this
on May 13, 2019
dmitshur

dmitshur commented on May 13, 2019

@dmitshur
Member

This task is a part of the larger "fully stripping down the godoc binary so that it only displays local code documentation" task in #29206 (comment).

Edit: Created issue #32011 for tracking that more specifically.

dmitshur

dmitshur commented on Sep 5, 2020

@dmitshur
Member

We should remove the one in x/website, as it's newer and unused. A better new home would be inside x/playground, but that can be a separate issue.

This caused confusion in CL 252377.

Edit: Not completely unused, I see #32007 (comment) above now.

added
NeedsInvestigationSomeone must examine and confirm this is a valid issue and not a duplicate of an existing one.
and removed
NeedsFixThe path to resolution is known, but the work has not been done.
on Sep 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    NeedsInvestigationSomeone must examine and confirm this is a valid issue and not a duplicate of an existing one.Thinkingwebsite

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @bradfitz@andybons@dmitshur@gopherbot@seankhliao

        Issue actions

          x/website: unify playground.js location · Issue #32007 · golang/go